Giter Club home page Giter Club logo

Comments (10)

drsm79 avatar drsm79 commented on July 28, 2024

metson: Hassen, is this still valid? I think all these changes went in to #95 or am I wrong?

from crabserver.

DMWMBot avatar DMWMBot commented on July 28, 2024

riahi: Not all changes went to #95. The patches, which went in #95, were to have AsyncStageout as component. I aligned the patches of this ticket with changes done in ticket #95.

from crabserver.

drsm79 avatar drsm79 commented on July 28, 2024

metson: ok, cool thanks Hassen! I'll bring my local repo up to sync with your changes and hopefully commit tonight.

from crabserver.

DMWMBot avatar DMWMBot commented on July 28, 2024

riahi: Perfect!...Thank you

Hassen

from crabserver.

drsm79 avatar drsm79 commented on July 28, 2024

metson: This patch series looks good, and has been committed.

I have a few questions:

  1. should TransferManager be removed? (I think yes)
  2. is ''defaultProxy'' in the config the servers certificate? (I think it should be)
  3. cleanSpace should probably reuse some code (not sure where from) to issue the appropriate delete command (IIRC lcg-rm is better in some cases) and/or deal with fallback/retries
  4. getFTServer should read the mapping from a file specified in the configuration, instead of a hardcoded list
  5. the orderFileAlgo should be replaced by changes to the CouchDB view, and how that's queried.

1 & 2 aren't a big deal (but I'd like to clarify before moving on). 3-5 should probably be separate tickets. If you agree can you open them and add the numbers to this ticket?

from crabserver.

drsm79 avatar drsm79 commented on July 28, 2024

metson: in fact getFTServer could use a database in couch... maybe over complicated.

from crabserver.

drsm79 avatar drsm79 commented on July 28, 2024

metson: oh, and one last thing:

  1. using subprocess.PIPE for stdin, stderr and stdout can lead to deadlocks when the command is verbose ([http://docs.python.org/library/subprocess.html#convenience-functions for more info]). ftscp is probably noisey enough to be a concern, so we should look at that (e.g. write to a log that is then parsed, rather than reading the stdout)

from crabserver.

drsm79 avatar drsm79 commented on July 28, 2024

metson: (In 8920) Change main class name, add defaultProxy parameter to config, implement ftscp machinery, references #311

From: Simon [email protected]

from crabserver.

DMWMBot avatar DMWMBot commented on July 28, 2024

riahi: I answer to your questions:

1- Yes, the TransferManager should be removed.
2- The defaultProxy is a valid user certificate in the server. I set this default value to be able to do tests and run transfers since a valid user certificate is needed to transfer files using ftscp as well as to remove files.
3- Yes maybe lcg-rm is better in some case. I'll open a new ticket to issue the appropriate delete command.
4- Yes, here we can use also a configuration file to have a mapping of FTS servers or get needed info from couch
5- I agree that orderFileAlgo should be replaced by changes to the CouchDB views to avoid complicated algorithms. I'll open a new ticket for this.
6- We should maybe evaluate this in an another ticket.

Cheers
Hassen

from crabserver.

drsm79 avatar drsm79 commented on July 28, 2024

metson: Ok, the other tickets are:
3: #337
4: #339
5: #338

Closing this one now.

from crabserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.