Giter Club home page Giter Club logo

Comments (16)

sfoulkes avatar sfoulkes commented on July 28, 2024

sfoulkes: This seems reasonable to me. I'd suggest using cherrypy to serve up the files as there is already support for that in WMCore and a cron'd script to prune older sandboxes as the disk fills up. Diagnostics and other bells and whistles would be built into the cherrypy server or the crab rest interface.

from crabserver.

ericvaandering avatar ericvaandering commented on July 28, 2024

ewv: A note to myself on how to implement this:

http://www.cherrypy.org/wiki/FileUpload

from crabserver.

ericvaandering avatar ericvaandering commented on July 28, 2024

ewv: Please review

Uses (modified) REST model for the uploading part, Page model for downloading.

from crabserver.

DMWMBot avatar DMWMBot commented on July 28, 2024

mmascher: Ouch... You are right it works. I' a moron...

from crabserver.

ericvaandering avatar ericvaandering commented on July 28, 2024

ewv: Simon, can you please review and then either check in or pass it on to someone else for further review?

from crabserver.

drsm79 avatar drsm79 commented on July 28, 2024

metson: The code in the patch looks fine from a quick look. However, shouldn't this be in CRAB and not WMCore? What other systems will have a UserFileCache?

from crabserver.

ericvaandering avatar ericvaandering commented on July 28, 2024

ewv: I don't have a strong opinion, but I put it in WMCore for two reasons.

  1. I wanted it started with the Local WQ/Agent cluster of things
  2. I figured it may be of more general use with MC workflows that have to ship big LHE files or whatever. Those could be run in production.

So make a decision and I will relocate it if needed.

from crabserver.

evansde77 avatar evansde77 commented on July 28, 2024

evansde: For 2, in the production case the LHE files will either be converted to EDM GEN files at CERN or shipped via squids or the DM system like normal data.
So I think that would make this Crab Only.

Question: Is there a maxmimum size limit on the input sandbox? The idea that a user could dump a couple of GB of data in there and send it to a batch system that copies it per job could lead to some issues with load, even with caching etc.

from crabserver.

ericvaandering avatar ericvaandering commented on July 28, 2024

ewv: At the moment there is no limit, but we can and should enforce something in the client, I think. I think CRAB2 enforces a 50 MB limit which comes from gLite. We had issues with PAT libraries being larger than that when they weren't in the release, but I haven't heard of that recently. So maybe 50 or 100 MB will be a good starting point.

So in answer to Simon's question, it sounds like I should relocate this to CRABServer.

from crabserver.

drsm79 avatar drsm79 commented on July 28, 2024

metson: Replying to [comment:11 ewv]:

So in answer to Simon's question, it sounds like I should relocate this to CRABServer.

Yeah, I think that's best. Also, the patch has no tests in it. Can you add them at the same time?

from crabserver.

ericvaandering avatar ericvaandering commented on July 28, 2024

ewv: Yeah. I'll have to find an example of tests for a web service.

from crabserver.

drsm79 avatar drsm79 commented on July 28, 2024

metson: https://svnweb.cern.ch/trac/CMSDMWM/browser/WMCore/trunk/test/python/WMCore_t/WebTools_t

from crabserver.

spigad avatar spigad commented on July 28, 2024

spiga: Replying to [comment:11 ewv]:

At the moment there is no limit, but we can and should enforce something in the client, I think. I think CRAB2 enforces a 50 MB limit which comes from gLite. We had issues with PAT libraries being larger than that when they weren't in the release, but I haven't heard of that recently. So maybe 50 or 100 MB will be a good starting point.

the limit we have now should be 100MB (the gLite limit was 10MB and apply to direct submission only). I agree to start with 100, also I'd made it configurable.

So in answer to Simon's question, it sounds like I should relocate this to CRABServer.

from crabserver.

ericvaandering avatar ericvaandering commented on July 28, 2024

ewv: Please review. New and improved with Unit tests

from crabserver.

ericvaandering avatar ericvaandering commented on July 28, 2024

ewv: Can this please be reviewed and checked in?

from crabserver.

spigad avatar spigad commented on July 28, 2024

spiga: As agreed I would give first the current stuff to integration and then move ahead.

Few things are still missing/not working on the deploy (including some problem I discovered yesterday which apparently doesn't show up it previous test?!?).

To be more precise: as soon as the next wmcore tag is cut we move on.

from crabserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.