Improve CRAB REST interface about crabserver HOT 6 CLOSED

spiga: Please Review

from crabserver.

metson: * I think if the config doesn't have an agentDN it would be better to die in the init than set it to None (probably the same for SandBoxCache_* variables, too)

• args=[''] is probably not necessary in the addMethod calls (looks like a typo - you've changed another addMethod call to args=[] in the patch)
• what difference is there between getServerInfo and getServerStatus? I'd see these as the same thing
• naming of variables is quite inconsistent - e.g in the getServerInfo:
  {{{
  result['AgentDN'] = self.agentDN
  result['my_proxy'] = 'myproxy.cern.ch'
  result['sandboxCacheType'] = 'gridFtp'
  # the following will change as soon as we follow up on #1305
  # at the moment is gridFTP specific.
  result['SandBoxCacheEndpoint'] = self.SandBoxCache_endpoint
  result['port'] = self.SandBoxCache_port
  result['basepath'] = self.SandBoxCache_basepath
  }}}
  could that become:
  {{{
  result['server_dn'] = self.agentDN
  result['my_proxy'] = 'myproxy.cern.ch'
  result['sandbox_type'] = 'gridFtp'
  # the following will change as soon as we follow up on #1305
  # at the moment is gridFTP specific.
  result['sandbox_endpoint'] = self.SandBoxCache_endpoint
  result['sandbox_port'] = self.SandBoxCache_port
  result['sandbox_basepath'] = self.SandBoxCache_basepath
  }}}
  or even better:
  {{{
  result['server_dn'] = self.agentDN
  result['my_proxy'] = 'myproxy.cern.ch'
  result['sandbox'] = {}
  result['sandbox']['type'] = 'gridFtp'
  # the following will change as soon as we follow up on #1305
  # at the moment is gridFTP specific.
  result['sandbox']['endpoint'] = self.SandBoxCache_endpoint
  result['sandbox']['port'] = self.SandBoxCache_port
  result['sandbox']['basepath'] = self.SandBoxCache_basepath
  }}}
• there are no unit tests for this...
• there's some trailing whitespace which I'll clean up

If you like I can make those changes and submit a patch to this ticket while you work on the unit tests?

from crabserver.

spiga: as you wish.
I'm realizing that I didn't submitted the last version.

info and status were supposed to be different.. info should return informations for the server operations.. status should give the status of the agent.. but since we are going through the rest for reqmgr... this should be not more needed.. probably we should discuss this based on the final model we'll propose/deploy

from crabserver.

spiga: Please Review

from crabserver.

metson: Unit tests are being tracked on #1329

from crabserver.

metson: closed with c62ee1b

from crabserver.