return NSImage instead of view about dswaveformimage HOT 5 CLOSED

Hey @Necrospasm, it sounds like you may be not be using WaveformImageDrawer directly.

Please refer to this example here:
https://github.com/dmrschmidt/DSWaveformImage#waveformimagedrawer---creates-a-uiimage-waveform-from-an-audio-file

On macOS, it'll create an NSImage instead of a UIImage.

If you run into problems with this approach, please let me know with the specifics and I can try to help :)

from dswaveformimage.

Hello @dmrschmidt, thanks for your reply. I did try that example before but for some reason it's not working for me. It's returning blank or errors out that the image is nil.

This is the code that I'm using :

let waveformImageDrawer = WaveformImageDrawer()
waveformImageDrawer.waveformImage(fromAudioAt: URL(fileURLWithPath: filenamePath), with: .init(
                                  size: NSSize(width: 80, height: 45),
                                  style: .filled(NSColor.black),
                                  position: .top)) { image in
    // need to jump back to main queue
    DispatchQueue.main.async {
        appData.generatedThumbnail = (image?.tiffRepresentation)!
    }
}

I tried various variations of the above code. I essentially don't need to push the image to a view to be displayed but to assign it to a data variable (@published var generatedThumbnail = Data()) so that I can save the image to a db blob (I know it's not the best approach but to my defence, it's just an 80x45 :P ) instead via a function DBManager.shared.addMedia(mediaThumbnail: appData.generatedThumbnail)

from dswaveformimage.

Since native macOS support was only added recently, I just double checked that this code really works on macOS in the latest version. And it does work for me in the example app.

So let's try debugging this step by step.

• If you check out this repo, try and run the macOS example app.
• Once that works, open the ContentView
• replace its body with the following code

    @State var image: NSImage?

    var body: some View {
        VStack {
            if let image {
                Image(nsImage: image)
            } else {
                Text("no image")
            }
        }.onAppear {
            let waveformImageDrawer = WaveformImageDrawer()
            waveformImageDrawer.waveformImage(fromAudioAt: audioURL, with: .init(
                                              size: NSSize(width: 80, height: 45),
                                              style: .filled(NSColor.black),
                                              position: .top)) { img in
                // need to jump back to main queue
                DispatchQueue.main.async {
                    self.image = img
                }
            }
        }
    }

That should give you this exact result:

Once you have that working, replace the audio file with the one you are trying to use. If that still results in nothing drawing, let's take it from there.

from dswaveformimage.

Your code worked and that got me thinking why it wasn't working in my project as the code is for the most part identical. So I created a new view, pasted your code and worked too. Then after about an hour scratching my head, I changed this line :

@published var generatedThumbnail = Data()
to
@published var generatedThumbnail: Data = Data()

and it worked. Not sure why though but maybe it will help someone else too. The only issue I'm having is that the first time i use the function, it doesn't generate anything. The second time running the function it does (without closing the app). Thank you so much for your help mate this is an awesome project.

from dswaveformimage.

Interesting and very obscure. Glad you found the culprit :) Have a great week!

from dswaveformimage.