We have a use case in Rails where we need to specify a cache key (from a Rails <code c

Added this feature in <a class="issue-link js-issue-link" data-error-text="Failed to l

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Adding an additional cache key about graphql-ruby-fragment_cache HOT 4 CLOSED

dmitrytsepelev commented on September 26, 2024

Adding an additional cache key

from graphql-ruby-fragment_cache.

Comments (4)

bbugh commented on September 26, 2024 1

Added this feature in #50

from graphql-ruby-fragment_cache.

DmitryTsepelev commented on September 26, 2024

Hi @bbugh! The feature sounds helpful, I wonder if it makes sense to use more general approach and pass custom key via options:

class CacheKeyBuilder
  key = "#{schema_cache_key}/#{query_cache_key}"
  key = "#{key}/#{options[:object_cache_key]}" if options[:object_cache_key]
  Digest::SHA1.hexdigest ...
end

cache_fragment(object_cache_key: where_class.whatever_we_want) { where_class.do_something }

from graphql-ruby-fragment_cache.

bbugh commented on September 26, 2024

That seems great! That also prevents having to change object_key in three places.

I think you'd have to also check for the options[:object_cache_key]:

key = "#{schema_cache_key}/#{query_cache_key}"
key = "#{key}/#{options[:object_cache_key]}" if options[:object_cache_key]
Digest::SHA1.hexdigest("#{schema_cache_key}/#{query_cache_key}").then do |base_key|
  next base_key unless object || options[:object_cache_key]
  "#{base_key}/#{object_key(object)}"
end

Maybe a little more readable:

def build
  Digest::SHA1.hexdigest("#{schema_cache_key}/#{query_cache_key}").then do |base_key|
    if options[:object_cache_key]
      "#{base_key}/#{options[:object_cache_key]}"
    elsif object
      "#{base_key}/#{object_key(object)}"
    else
      base_key
    end
  end
end