plonk.visualize.plot passes colorbar_kwargs to imshow about plonk HOT 2 CLOSED

Hi @joshcalcino, thanks for raising this issue.

Which version of Plonk are you using? You can get this by printing plonk.__version__.

I have released a new version of Plonk (v0.5.0) today. In this version I have removed the Visualization class in favour of a function (plonk.visualize.plot) that returns a Matplotlib Axes object. I think this makes the code simpler, and more general. And it's easier for the user who might be already familiar with Matplotlib.

I've tested your code with v0.5.0 and it works as expected.

Also another thing I noticed in the documentation for plonk.visualize.plot, it states it returns a matplotlib axes object:

On readthedocs there are two versions: one that is pinned to the most recent release installable via pip or conda (https://plonk.readthedocs.io/en/stable/) which is called "stable" and one that is the current master branch of the development version on GitHub (https://plonk.readthedocs.io/en/latest/) that is called "latest". I think you were looking at the development version, i.e. "latest", not the "stable" one.

I am also wondering if it is possible to make the plot_object object available to the user somehow in the above object, or make it accessible some other way.

I guess now that there is no Visualization object you can just access the required Matplotlib objects via the Axes object. (Although you could do this previously.) For example, to change the colorbar range:

ax = plonk.visualize.plot(snap=snap, quantity='density')
im = ax.images[0]
im.set_clim(vmax=1/137)

Let me know what you think.

from plonk.

Hi @joshcalcino , let me know if you have any more questions or concerns regarding this issue. If not, I'll close the issue.

from plonk.