Giter Club home page Giter Club logo

Comments (6)

wulf7 avatar wulf7 commented on July 19, 2024

Aside from the expected IN_OPEN, IN_CLOSE_WRITE and IN_CLOSE_NOWRITE failures what am I missing here to get all the tests passing?

Kernel should be patched to pass all the tests as it reqired some kqueue and open() extensions. These patches can be found in "patches" subdirectory and should be applied to 6-month old CURRENT. They require trivial updating to be applied to 10.2 or fresh CURRENT
The result you got is expected for tests running on stock kernel except the last error: "watch id is -1, errno set to EACCES when starting watching a file without read access". But I cant reproduce this error in 10.2 running in virtualbox

from libinotify-kqueue.

wulf7 avatar wulf7 commented on July 19, 2024

except the last error: "watch id is -1, errno set to EACCES when starting watching a file without read access". But I cant reproduce this error in 10.2 running in virtualbox

Are you tried to run tests as root?

from libinotify-kqueue.

infracaninophile avatar infracaninophile commented on July 19, 2024

On 09/15/15 11:58, Vladimir Kondratiev wrote:

Are you tried to run tests as root?

Yes, exactly.

Cheers,

Matthew

from libinotify-kqueue.

wulf7 avatar wulf7 commented on July 19, 2024

Are you tried to run tests as root?

Yes, exactly.

Tried this on EL6.4 just now an found that Linux root is able to open files with 000 permissions for watching also. So this issue can be considered as testsuite bug. Could you run tests as ordinary user?

P.S. Thanks for reporting this.

from libinotify-kqueue.

infracaninophile avatar infracaninophile commented on July 19, 2024

On 09/15/15 12:43, Vladimir Kondratiev wrote:

Are you tried to run tests as root?

Yes, exactly.

Tried this on EL6.4 just now an found that Linux root is able to open files with 000 permissions for watching also. So this issue can be considered as testsuite bug. Could you run tests as ordinary user?

P.S. Thanks for reporting this.

If I run the tests as an ordinary user the EACCES failure doesn't occur.

Running test suite...
...................xx..................xx............xx..................................x...x....x.x.....x.x..........

In test "Directory notifications":
    failed: receive IN_MOVED_FROM event on moving file from directory to
another location within the same mount point
    failed: receive IN_MOVED_TO event on moving file to directory from
another location within the same mount point

In test "Open/close notifications":
    failed: receive IN_OPEN on cat
    failed: receive IN_CLOSE_NOWRITE on cat
    failed: receive IN_OPEN on ls
    failed: receive IN_CLOSE_NOWRITE on ls
    failed: receive IN_OPEN on modify
    failed: receive IN_CLOSE_WRITE on modify

In test "Symbolic links":
    failed: Start watch successfully on a symlink file with IN_DONT_FOLLOW
    failed: Receive IN_ATTRIB after touching symlink itself
    failed: Receive IN_MOVE_SELF after moving the symlink
    failed: Receive IN_DELETE_SELF after removing the symlink

--------------------
     Run: 119
  Passed: 107
  Failed: 12

PS. I'm just about to submit a PR to get the FreeBSD ports updated to
the latest version of libinotify.

Cheers,

Matthew

from libinotify-kqueue.

wulf7 avatar wulf7 commented on July 19, 2024

There are no unexpected failures now.

P.S. Thanks again for report and plz dont close this issue as it reveals a false-positive in test suite

from libinotify-kqueue.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.