Giter Club home page Giter Club logo

Comments (6)

dlew avatar dlew commented on August 16, 2024

Are you using Eclipse or Gradle? I wonder where this manifests.

The core problem is that org.joda.convert (which is a pre-compiled dependency) uses java.xml.bind. When I looked into the source it wasn't a problem because joda-time doesn't use the method that requires it, but I had to include a lint.xml that got rid of the error. However, it looks like that same error shows up when anyone depending on the library uses it...

Three options spring to the top of my head:

  1. Use proguard to remove the offending method/class during AAR compilation. (Not sure if this will work for Eclipse builds, though.)
  2. Figure out some way to include my lint.xml in future builds. (Again, not sure if Eclipse will support.)
  3. Include joda-time-convert and remove the offending classes.

from joda-time-android.

zmalltalker avatar zmalltalker commented on August 16, 2024

Thanks for the quick feedback, @dlew
I didn't realize the cause was from pre-compiled dependencies, I was probably a little quick in reporting this. That taken into consideration this looks like something I should take care of in my project, which I already did.

Oh, and I use gradle (does anyone really still use Eclipse? :trollface:)

from joda-time-android.

dlew avatar dlew commented on August 16, 2024

I should take care of it in at least the AAR as well. It doesn't make sense to keep around classes that aren't used and cause lint errors. :P

from joda-time-android.

zmalltalker avatar zmalltalker commented on August 16, 2024

Awesome!

from joda-time-android.

dlew avatar dlew commented on August 16, 2024

This is proving a lot trickier than I thought. I can't just proguard the offending class out because it's being used elsewhere (just not the one method that would cause Android to blow up). And I can't pass lint rules downstream for just this library, either.

I'm asking to see if I can get a version of joda-convert which doesn't use javax.xml.bind. Alternatively I guess I could import all of joda-convert and remove the offending class...

from joda-time-android.

dlew avatar dlew commented on August 16, 2024

That's what I decided to do. If joda-convert stops using javax.xml.bind then I'll switch back to using it as a dependency. a5871b0

from joda-time-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.