Comments (6)
Added in a PR for multiple passes, afaik anything beyond 2 is inconsequential, so I hard-coded that in for now in the #19
from audio-visualizer-python.
We will need to rework this into the newgui
branch.
from audio-visualizer-python.
Yeah, should be much easier once there is an options drop-down for it that we can pull from, or whatever.
from audio-visualizer-python.
Quite new to ffmpeg myself and encoding in general, but can someone confirm/clarify something for me:
By default, when you encode in x264, ffmpeg uses a crf with a factor of 23 or so.
Once you specify what bitrate you want, you can do multi-pass encoding.
In that case for our new GUI we would need to incorporate a radio button to switch between those two options as they are incompatible with each other. Or a separate "bitrate"/"quality" tab where we can specify the various options for CRF and Multi-pass encoding, like:
Setting for both:
Preset: Ultra fast to very slow, determines compression, default = medium
CRF:
Value: 0-51 quality, 0 is lossless, 51 is the worst. default = 23
Multi-pass:
Number of passes
Bitrate for each pass
from audio-visualizer-python.
Perhaps we should separate the encoder settings widget into its own file with a separate ui file, so it's easier to manage this complexity as more settings are added.
from audio-visualizer-python.
I separated 1 encoder pass into its own method, and tried adding a 2-pass encoding option based on @ardeaf's pull request #19
Branch here: https://github.com/djfun/audio-visualizer-python/tree/feat-2-pass-encoding
Note: the 2-pass encoding breaks if using Video, Spectrum, or Waveform components. That would be easy to fix later.
It seems to work at some video bitrates (1200 with my test audio) and will produce slightly different videos, but I don't really know how to tell if I'm doing it right nor how to tell which bitrates would actually work. We have to detect that ahead-of-time.
If anyone still wants this feature, please let me know :)
from audio-visualizer-python.
Related Issues (20)
- Relative positioning and dimensions for everything HOT 2
- setup.py broken in feature-newgui branch HOT 17
- Video component causes inaccurate progress bar HOT 4
- TypeError: 'QByteArray' does not have the buffer interface HOT 1
- Undo/redo functionality HOT 1
- No module named 'PyQt4' HOT 6
- Running the main.py shows segmentation fault!!!
- Problem
- Repo Name
- TypeError - video_thread.py tries to join a string and an int HOT 1
- Color issue HOT 2
- Changing the location of the visual effects HOT 1
- Add a screenshot and a demo video on YouTube. HOT 1
- An Appimage version of the appliacation HOT 1
- Make v2 (newgui) installable HOT 2
- Crash when exporting video in GUI mode
- Outdated macOS installation instructions
- Waveform component is too sensitive/fast
- Conway's component does not prevent infinite growth
- Call render from a component HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from audio-visualizer-python.