Giter Club home page Giter Club logo

Comments (4)

justinkb avatar justinkb commented on May 9, 2024 2

Conversely, when it is definitely a Genn/Baku deck, it also fails to recognize that

from advisor.

chWolfgang avatar chWolfgang commented on May 9, 2024

Just checking to see if I have missed something? Really hoping this gets fixed. I love this plug in, but it a little less useful when it makes a mistake with odd/even decks.

Thanks for all your effort(s) with this!

from advisor.

djdookie avatar djdookie commented on May 9, 2024

Hey guys, thanks for your comments.
Until now, Advisor solely relies on similarity calculation between HDT's opponent's played (not seen) card list and your archetype deck database to choose the highest match. There is no further logic.

We would need to have some extra logic like:

  • Baku was seen (not played) -> drop all decks without Baku for prediction
  • Genn was seen (not played) ->drop all decks without Genn for prediction
  • Baku was not seen -> drop all decks with Baku for prediction
  • Genn was not seen ->drop all decks with Genn for prediction

I don't really like the idea of extra logic for special cards, because Advisor uses a general approach to predict decks. Apart from that this should only be an issue for the very first turns in odd/even decks.

Furthermore I don't have the free time to continue development and I consider Advisor being (core) feature complete (the above is just a convenience feature).

But feel free to improve the code yourself and make a pull request!

from advisor.

atsepkov avatar atsepkov commented on May 9, 2024

I came here for the same reason. My familiarity with this project and HDT is only a skin deep from glancing at the source code, but could special-casing Baku and Genn be avoided by treating them the same way as OnOpponentJoustReveal trigger?

from advisor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.