Use of `bot.api` about ban_appeal_plugin HOT 3 CLOSED

https://github.com/kyb3r/modmail/wiki/Plugins#database-interfacing Says:

Do not interact with bot.api directly. Fetch a partition and use it:

Yet, in https://github.com/DjDeveloperr/ban_appeal_plugin/blob/main/ban_appeal/ban_appeal.py#L299 self.bot.api is directly called for the post_log method. Is this not possible to due through the partition?

Additionally, that's under the section "Database Interfacing", but I notice bot.db is being used directly? Are the interactions there not possible through a partition?

I'm not very experienced with Python, nor have I done a deep dive of Modmail's codebase, so if there's something I'm missing here, just let me know.

The reason why I’m using self.bot.api instead of a plugin partition is due to adding messages to the logviewer. If you look closely at the modmail code base that method is used to close a thread and send the closed information to the log viewer. The log viewer only checks data for the logs collection, so if I make use of a partition it would lead into another fuckery with internals of modmail and even might need to edit log viewer.

I’m directly interfacing with bot.db for a couple of reasons, main one being having all data in the same mongodb database. If I use a plugin partition instead the webserver would need to be edited and changed to follow this partition and iirc changing the plugins class name will result in creating another partition which is I don’t want to go with. By directly working with bot.db, I could easily access the appeal config collection.

from ban_appeal_plugin.

Let me know if you have any more questions, and apologies if I worded something not well I suck at English sometimes.

from ban_appeal_plugin.

That makes sense to me.

from ban_appeal_plugin.