Spec question: `websocket.disconnect` doesn't support the `reason` field about asgiref HOT 10 CLOSED

Can you give me some days to reply here? I'm on vacation, but I'm back next week.

from asgiref.

Sure! Enjoy your holidays 🌴

from asgiref.

They can, if I understand correctly the spec. It's apparently supported by browsers API: https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/close

from asgiref.

Then I don't mind adding it.

from asgiref.

I do not remember a specific reason; it was likely either an oversight or the libraries I developed the spec against last decade didn't support it.

from asgiref.

Thank you for your feedback 🙂 Then, do you see any inconvenience if I propose a PR to add this to the spec?

from asgiref.

Hey @Kludex 👋 Did you have some time to think about this? 🙂

from asgiref.

It looks like an oversight, but... No one complained in years... Do you need it?

from asgiref.

Well, not a really big issue but yes, I had one complain downstream in httpx-ws. Relevant context:

• encode/uvicorn#2299
• frankie567/httpx-ws#70

IMHO, it looks like a harmless addition that would make the spec a bit more compliant regarding WS spec. Happy to make the PR, if you agree 🙂

from asgiref.

Do the WebSockets clients send the "reason"?

from asgiref.