Giter Club home page Giter Club logo

Comments (7)

kavdev avatar kavdev commented on July 19, 2024

Sorry it took so long for me to get around to this, but #64. Please give it a shot and let me know if I missed anything.

from djangotoolbox.

FeroxTL avatar FeroxTL commented on July 19, 2024

There are some imports, that does not work in 1.8, what must be:

#base.py
from django.conf import settings
from django.db.backends.base.features import BaseDatabaseFeatures
from django.db.backends.base.operations import BaseDatabaseOperations
from django.db.backends.base.base import BaseDatabaseWrapper
from django.db.backends.base.client import BaseDatabaseClient
from django.db.backends.base.validation import BaseDatabaseValidation
from django.db.backends.base.introspection import BaseDatabaseIntrospection

#creation.py
from django.db.backends.base.creation import BaseDatabaseCreation

from djangotoolbox.

kavdev avatar kavdev commented on July 19, 2024

Not sure why you're getting an error, but those imports are indeed correct. See here

from djangotoolbox.

kavdev avatar kavdev commented on July 19, 2024

I've committed more changes since you've looked at it though; there might have been a bug that should now be resolved.

from djangotoolbox.

FeroxTL avatar FeroxTL commented on July 19, 2024

In master branch are another imports https://github.com/django-nonrel/djangotoolbox/blob/master/djangotoolbox/db/base.py#L5

In django 1.7.x it worked, because all imports were in init file https://github.com/django/django/blob/stable/1.7.x/django/db/backends/__init__.py
But in 1.8 this file is empty, so all imported classes are in another location https://github.com/django/django/blob/stable/1.8.x/django/db/backends/__init__.py

In my last comment I wrote how it must be imported in 1.8. One more thing - there must be checking that django is 1.8

from djangotoolbox.

kavdev avatar kavdev commented on July 19, 2024

The pull request I mentioned (#64) was created to fix all off the issues you've mentioned. If you want to test the new changes, you need to checkout the incoming changeset.

from djangotoolbox.

aburgel avatar aburgel commented on July 19, 2024

Fixed in #64

from djangotoolbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.