Add type hints about django-import-export HOT 3 CLOSED

Hi - thanks for the offer of help. I would agree with the view that it would be nice to have, but probably not required for a project like this. Therefore I would conclude that we don't need type hints at this time.

If any other users have a view on this, they can add to this thread, and we can keep it in mind for later versions such as v5.

from django-import-export.

Thanks @Viicos for opening this issue. Do you know of any other large Django projects that have embraced type hints? And what has the reaction been like from the community after they added them?

In a declarative library like django-import-export, Im struggling to see the benefits of adding them.

from django-import-export.

I recently did it in django-modeltranslation (but it isn't merged yet). My personal experience with it is that:

• whenever a library is dealing with Django internals, it gets tricky (sometimes Django stubs are incorrect, and dynamic stuff is hard to support). But it did help understand what django-modeltranslation was doing in some cases.
• The benefit for declarative libraries is limited (from an end user perspective), however I can see the benefit for some public methods called by such end users (resource.export(), modelresource_factory for instance).

So I think type hints would still be a nice addition (as stubs or in the library), although I do agree it isn't a strong requirement as most of the library is declarative

from django-import-export.