Video : typo in source type ? about diveintohtml5 HOT 5 CLOSED

Hi Jerome!

Actually, the problem here is the extra double quote on type attribute just follow codecs=:

source src="pr6.ogv" type="video/ogg; codecs="theora, vorbis"

I've just removed it and formatted the type attribute per W3C specs that specify multiple codecs must be wrapped by a single quote (')

http://www.w3.org/TR/2008/WD-html5-20080122/#the-source

Thanks!

@paulirish and @jonathantneal

These changes are ready to be pulled if you accept them.

Thanks!

from diveintohtml5.

@estebanav, where does it say the single quote is required? Have you checked to see if this works cross browser? I believe the problem was only the extra double quote, which appears to have already been fixed in another update (viewing the source of the page).

from diveintohtml5.

Hi all.

Tue, 01 Jan 2013 11:30:34 -0800
Jonathan Neal a écrit:

@estebanav, where does it say the single quote is required? Have you
checked to see if this works cross browser? I believe the problem was only
the extra double quote, which appears to have already been fixed in another
update (viewing the source of the page).

I didn't notice the extra double quote. It is unrelated. My troubles were with
the webm part. I did not try ogv and therefore did not copy the ogv line.

Jérôme

from diveintohtml5.

@jonathantneal

where does it say the single quote is required?

In the following link to W3C HTML5's Specs the codecs attribute appear enclosed by double-quotes, so I assumed that multiple attributes within an attribute must be wrapped by single or double quotes.

http://www.w3.org/html/wg/drafts/html/master/embedded-content-0.html#the-source-element

Have you checked to see if this works cross browser?

Yes, I did it :)

@jerome-github

I think the problem is the extra double quote that is broken the HTML and that's why FF is not rendering correctly and codecs might be wrapped by single or double quotes as I wrote above.

from diveintohtml5.

The typo was in my repository. I am so close to having them in sync. It should be corrected.

from diveintohtml5.