Large pacts over 1mb are rejected by nginx config about pact_broker-docker HOT 6 CLOSED

The image I have created with the change in, is published here https://hub.docker.com/r/you54f/pact-broker-nginx. 👍

from pact_broker-docker.

Hey, sorry. I only just saw this. Just wondering what, if any, negative implications there might be for increasing it to 10MB?

from pact_broker-docker.

No worries duck,

I'll do some reading up on any potential side-effects, I think setting it too high could open a web-service up to DOS attacks, but with it only being 10mb, I don't think it makes much of an issue.

We have slimmed down the pacts now by using a much smaller encoded base64 string, so our pacts are no longer over 1mb

I've recently been trialling pb with puma (https://github.com/YOU54F/pact-standalone-docker-slim/tree/master/pact_broker_puma) and currently messing about with trying to get pact broker working in AWS lambda.

Have any of your other customers ever had issues with large pacts? Looking at the issues logs, I seem to the only one who has raised this?

from pact_broker-docker.

I'm thinking this may be redundant now the new puma version is out? Once it's stable, I'll be deprecating this image.

from pact_broker-docker.

Oh, and yes, you're the first to raise this!

from pact_broker-docker.

Thanks @bethesque, I’ll trial the new puma based image at work next week and pass back any feedback 👌

from pact_broker-docker.