Giter Club home page Giter Club logo

Comments (6)

YaLTeR avatar YaLTeR commented on July 23, 2024 1

Alright, I understand, thanks for the response.

from discord-rpc.

Emzi0767 avatar Emzi0767 commented on July 23, 2024 1

Windows XP is dead. Having a computer running XP connected to the internet is nothing but irresponsible. Nobody will go any extra mile to fix an issue with an operating system this old.

You should tell your users to move to an operating system that is not 16 years old. If you really want to support XP, fork the repo, make the changes yourself, and distribute your modified version of the library. But that's a waste of effort in my opinion.

from discord-rpc.

msciotti avatar msciotti commented on July 23, 2024

While a valid use case, Discord unfortunately does not support Windows XP in an official or unofficial capacity. Apologies that we can't offer more help with it, but we won't change the SDK for non-supported Windows versions.

from discord-rpc.

Solybum avatar Solybum commented on July 23, 2024

I encountered this issue as well.
Due to the registry functions, it's not possible to use the library in XP.

@msciotti I don't think it needs any SDK changes, in fact I built it in VS2017, SDK 10.0.16299.0, Toolset v141 (not the xp support variant) and it works fine in XP.
(The library that the game interacts with is built with xp toolset though).

The discord-rpc code is not used in XP given the fact that discord won't run in XP, but at least this allows the game to run in XP with discord rpc statically linked.

Here are the changes I did to the registry functions

from discord-rpc.

msciotti avatar msciotti commented on July 23, 2024

@Solybum appreciate your linking your fix. If you're interested, I'd be happy to have you PR that logic in a conditional block to at least allow people to run their games on Windows XP without the SDK being a blocker.

from discord-rpc.

Solybum avatar Solybum commented on July 23, 2024

Do you think it would be ok to just change the registry functions to their older variant without any conditional compilation?

As per the comment at the beginning of the file.

some of functions used here require WINNT >= 6.0 APIs
Such API is e.g. RegSetKeyValueW.

However, RegOpenKeyExW and RegSetValueExW should work here too.
The problem is that linking the library on a different project with XP support won't be able to find the functions currently used.

from discord-rpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.