Giter Club home page Giter Club logo

Comments (7)

crmarsh avatar crmarsh commented on July 23, 2024 3

Fixed on canary and ptb, should get to stable soon.

from discord-rpc.

crmarsh avatar crmarsh commented on July 23, 2024 2

Should be fixed in stable now.

from discord-rpc.

crmarsh avatar crmarsh commented on July 23, 2024

Discord_Shutdown clears out the callback pointers so none of them are called, shuts down the io thread, and closes the connection to Discord. The intent was for this to get called as your game shuts down, but it is safe to call whenever and re-init later if you want.

Right now the Playing <game> status in Discord is driven by the process existing, not by the rpc connection. We're planning to add an explicit call to disable it, though.

from discord-rpc.

EngiN33R avatar EngiN33R commented on July 23, 2024

But the process doesn't exist in my scenario. For example, this was taken 5 minutes after starting send-presence.exe, typing f into the prompt, and closing it as soon as Discord: ready was shown. As you can see, no send-presence process exists, but the RP info is still displayed with the time left having counted down to 00:00.

image

from discord-rpc.

No-Half-Measures avatar No-Half-Measures commented on July 23, 2024

Looking at the Send-Presence example 'Discord_Shutdown' is called twice when you 'quit' using the q input option it causes this issue, I actually did this in my own code too accidentally and had the same issue where the rich presence status was stuck displayed even though the process had closed after the 'Discord_Shutdown' function was called (all be it was twice).
After removing the second un-needed execution of the 'Discord_Shutdown' function and testing it seemed to have fixed it in my code/senario... Could this be an issue then with executing 'Discord_Shutdown' more than once? If that's the case even though you shouldn't there probably should be something stopping this issue from even happening in the first place.

from discord-rpc.

crmarsh avatar crmarsh commented on July 23, 2024

Nah, Discord_Shutdown should be safe to call a second time. That sounds like a bug on Discord's side.

from discord-rpc.

StrikerMan780 avatar StrikerMan780 commented on July 23, 2024

Good that this is fixed. I thought I was going crazy.

from discord-rpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.