Suggestion: RegExp prefix's about klasa HOT 10 CLOSED

Uh, this was a thing... If it's broken, that's a bug.

from klasa.

Confirmed bug

from klasa.

this.client.config.prefix has never been RegExp but string/string[]. This suggestion breaks several pieces including SettingGateway. Althought SGv2 will just throw a TypeError.

from klasa.

I'm sure it was a thing in August I remember using it but I could be tripping this might break SGv2 but maybe there could be a RegexPrefix option in KlasaClientConfig so that RegexPrefix is the main prefix that couldn't be overridden aka Hey Skyra, ping would work always even if you used conf to change the prefix so it is not overridable.

from klasa.

Just like Komada 0.19.7's usage were so bugged the repeator tag was useless and it was capturing from the argument's position to the end (infinite catching), it got fixed in 0.20.0 with Ao's rewrite and that behaviour dissapeared. There has not been an infinite catching feature in Komada, nor in Klasa, although a bug allowed it to exist.

Same happens here with the prefixes, this.client.config.prefix being a RegExp (but guild prefixes defaulted to string|string[]). That was an unintended behaviour that worked due to a bug, but since the bug is now fixed, that does not longer work.

from klasa.

I see

from klasa.

@kyranet What is your opinion on the regexPrefix option in KlasaClientConfig? I think it would become handy

from klasa.

as mentionPrefix shouldn't be overridden and is only meant for mentionPrefix for the bot...

from klasa.

My opinion is that regexPrefix is a nice-to-have feature, but most developers will not find it handy. (Keep in mind that RegExp is a feature that many newbie developers find hard to use).

from klasa.

I can agree with it being a nice feature to have and very true that noobie developers dont know the power of Regular expresions

from klasa.