Giter Club home page Giter Club logo

Comments (12)

UnseenFaith avatar UnseenFaith commented on July 23, 2024 1

Every piece could have a subfolder property (similar to category/subcategory in commands) in which would contain the location of the piece. Every piece would have it assigned to variable its suppose to be or null, and then can be used in the piece that it might be needed in, i.e. for appliesTo.

Issues I could see with this:
- Performance drops for having to read extra dirs that may or may not be empty. (All other pieces beside commands to my knowledge only read the top dir). Klasa does this already.

  • Pieces that require specific subfolder names would error.

from klasa.

DevYukine avatar DevYukine commented on July 23, 2024

+1 to this idea, makes it way more organizied and this should be easy to implement since klasa kinda does something simular to command folder

from klasa.

UnseenFaith avatar UnseenFaith commented on July 23, 2024

If this idea is implemented, it should be moved to the base class, and all of the pieces should inherit it, regardless of whether they use it or not to keep it consistent.

from klasa.

tech6hutch avatar tech6hutch commented on July 23, 2024

Would subfolder just be ignored if they don't use it?

from klasa.

tech6hutch avatar tech6hutch commented on July 23, 2024

Edit: I thought of another caveat

from klasa.

tech6hutch avatar tech6hutch commented on July 23, 2024

Fair point, but what do you mean by "Pieces that require specific subfolder names would error"?

from klasa.

UnseenFaith avatar UnseenFaith commented on July 23, 2024

So like if you want to have a User extendables folder, and you incorrectly spelled User or anything that would make it not "User" when you try to apply it, it would fail.

from klasa.

kyranet avatar kyranet commented on July 23, 2024

Your proposal lacks of a little detail: the option klasa from ExtendableOptions.

from klasa.

Stitch07 avatar Stitch07 commented on July 23, 2024

I like this. IMO the klasa ones should go into a subcategory called klasa and have an appliesTo arg regardless.

from klasa.

tech6hutch avatar tech6hutch commented on July 23, 2024

Jacz suggested that, too. ./extendables/klasa/KlasaUser/profile.js

from klasa.

tech6hutch avatar tech6hutch commented on July 23, 2024

Oh, I misunderstood you. That would work, too.

from klasa.

bdistin avatar bdistin commented on July 23, 2024

No, while you can already organize pieces into subfolders, it's not really fitting to make that have meaning here.

from klasa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.