Comments (12)
Every piece could have a subfolder property (similar to category/subcategory in commands) in which would contain the location of the piece. Every piece would have it assigned to variable its suppose to be or null, and then can be used in the piece that it might be needed in, i.e. for appliesTo.
Issues I could see with this:
- Performance drops for having to read extra dirs that may or may not be empty. (All other pieces beside commands to my knowledge only read the top dir). Klasa does this already.
- Pieces that require specific subfolder names would error.
from klasa.
+1 to this idea, makes it way more organizied and this should be easy to implement since klasa kinda does something simular to command folder
from klasa.
If this idea is implemented, it should be moved to the base class, and all of the pieces should inherit it, regardless of whether they use it or not to keep it consistent.
from klasa.
Would subfolder just be ignored if they don't use it?
from klasa.
Edit: I thought of another caveat
from klasa.
Fair point, but what do you mean by "Pieces that require specific subfolder names would error"?
from klasa.
So like if you want to have a User extendables folder, and you incorrectly spelled User or anything that would make it not "User" when you try to apply it, it would fail.
from klasa.
Your proposal lacks of a little detail: the option klasa
from ExtendableOptions.
from klasa.
I like this. IMO the klasa ones should go into a subcategory called klasa and have an appliesTo arg regardless.
from klasa.
Jacz suggested that, too. ./extendables/klasa/KlasaUser/profile.js
from klasa.
Oh, I misunderstood you. That would work, too.
from klasa.
No, while you can already organize pieces into subfolders, it's not really fitting to make that have meaning here.
from klasa.
Related Issues (20)
- docs do not works HOT 2
- build broken HOT 2
- Documentation is not opening HOT 1
- Rename extendables to mixins HOT 1
- Documentation not working HOT 1
- Incorrect Docs Link and subsequent GitHub Link HOT 2
- Settings#update() returns the wrong data
- Unable to see any page from the documentation. HOT 5
- SettingsGateway Type Role with Sqlite Provider returning the wrong id HOT 4
- Reaction handler does not check for DM, causes error
- Module '"discord.js"' has no exported member 'ClientApplication'. HOT 7
- NPM listing is out of date HOT 5
- Broadcast Eval bug
- Message#flags being incompatible
- i18n Friendly
- Klasa SQLProvider class does not check for instanceof MemberGateway in klasa-member-gateway
- Klasa ReactionHandler unstable behavior when messages are deleted HOT 2
- FS-NEXTRA error when interacting with settings. HOT 2
- RichDisplayRunOptions.jump - Allow jumping to info page.
- Bug: Concurrency is broken in Schedule
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from klasa.