Giter Club home page Giter Club logo

Comments (3)

thatbudakguy avatar thatbudakguy commented on June 2, 2024 1

cool, readings_exceptions or readings_archaic or something makes sense to me.

from jdsw.

thatbudakguy avatar thatbudakguy commented on June 2, 2024

Right now this is controlled by:

def is_valid_reading(self, char: str, reading: str) -> bool:
return reading in self.readings_for(char)

where readings_for() just checks our SBGY file, so I could easily have it output a warning when rejecting things.

Do you think it's appropriate in this case to just add the readings to your GDR-SBGY-full.csv? If not, probably not too difficult to expand the Reconstruction class in lib/phonology.py to allow augmenting the sound table with more information after it's constructed.

from jdsw.

GDRom avatar GDRom commented on June 2, 2024

Thanks for pointing to the right line of code for this. Yeah, adding such a warning output would be great so I can analyze where things clash between the SBGY and the JDSW.

As for whether or not to append these readings to GDR-SBGY-full.csv -- I think better not, as I think that data should be left as is. The example I provided above should not occur in the vast majority of medieval texts, nor in "regular" Han texts, but only in that domain of texts that is decidedly archaic (shangshu, maoshi, yijing etc.). I'd estimate that the same will be true for most, if not all, "correct" readings that are omitted in the SBGY.
I'd hence say those are clear exceptions; perhaps a separate readings_exceptions.csv or so might be a better place to store those?

from jdsw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.