Comments (5)
Hey Sebastian, thanks for filing this issue that's an excellent suggestion.
To use the StarWars code as an example, I would imagine something like this:
type alias DroidArgsRequired =
{ id : Swapi.Scalar.Id }
droid : DroidArgsRequired -> SelectionSet decodesTo Swapi.Object.Droid -> Field (Maybe decodesTo) RootQuery
-- ...
type alias HeroArgsOptional =
{ episode : OptionalArgument Swapi.Enum.Episode.Episode }
hero : (HeroArgsOptional -> HeroArgsOptional) -> SelectionSet decodesTo Swapi.Interface.Character -> Field decodesTo RootQuery
-- ...
What do you think of that naming convention?
from elm-graphql.
I think is fine.
However as you already named optional arguments OptionalArgument
, maybe it makes sense something like HeroOptionalArguments
so it feels more consistent?
Either way is fine.
from elm-graphql.
Great point, ๐ for consistency.
from elm-graphql.
@sporto The latest npm package is now generating type aliases for optional arguments. I will try to add the code generation for required argument type aliases before my trip tomorrow!
Let me know if there's anything you think could be improved with it. Thanks!
from elm-graphql.
@sporto it is now generating type aliases for required args as well, I think it's all set now! Feel free to reply if you see issues or have suggestions though.
from elm-graphql.
Related Issues (20)
- Enhancement - Add support for Dgraph HOT 1
- non null list of non null list ofโฆ HOT 6
- Include an exhaustive query for each type HOT 3
- elm-graphql generation fails if there are no columns selected (Hasura) HOT 6
- Add operationName to mutation request body HOT 1
- Enum with underscore as a leading character, changed after generating elm code. HOT 1
- Scalar decoder fails when the field contains an object. HOT 1
- Scalars should not be encoded as json in mutations HOT 3
- Enforce nonempty list in required list arguments HOT 3
- Selecting implementation attributes from interfaces HOT 2
- Corrupt package data for 5.0.5? HOT 1
- Requesting feedback on the following changes to the serializeChildren function regarding field hashing HOT 2
- Can not find ScalarCodecs HOT 1
- Feature request: Convenience functions for primitive comparisons HOT 3
- Idea: serialize invalid JSON Input Values as arguments
- Missing fragment in Interface `Fragments` type HOT 1
- Idea: include deprecation warnings into the generated code as comments HOT 1
- Building large queries takes a long time and pauses the UI HOT 2
- Encode function for enums is missing HOT 1
- Generate input object helpers HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elm-graphql.