Giter Club home page Giter Club logo

Comments (2)

gmaclennan avatar gmaclennan commented on August 18, 2024

It would be important to test whether this is actually a performance issue first. Updates already get queued up in a single animation frame update. I don't think firing window.onresize has any performance implications e.g. Firing it once vs firing 10 times won't gain anything compared with the repaint cost. Also, from an app design perspective, if possible it would make more sense to wrap an outer component in react-dimensions and pass down the props and calculate widths and heights from them. There is only one browser window so you only need those values once and everything else can be calculated.

from react-dimensions.

timkindberg avatar timkindberg commented on August 18, 2024

Ah I see... I didn't realize it was essentially batched. Now I see it here: https://github.com/digidem/react-dimensions/blob/master/index.jsx#L105-L111

Nevermind then. If we notice a problem we will reopen.

from react-dimensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.