Comments (2)
It would be important to test whether this is actually a performance issue first. Updates already get queued up in a single animation frame update. I don't think firing window.onresize has any performance implications e.g. Firing it once vs firing 10 times won't gain anything compared with the repaint cost. Also, from an app design perspective, if possible it would make more sense to wrap an outer component in react-dimensions and pass down the props and calculate widths and heights from them. There is only one browser window so you only need those values once and everything else can be calculated.
from react-dimensions.
Ah I see... I didn't realize it was essentially batched. Now I see it here: https://github.com/digidem/react-dimensions/blob/master/index.jsx#L105-L111
Nevermind then. If we notice a problem we will reopen.
from react-dimensions.
Related Issues (20)
- Fallback when requestAnimationFrame is unavailable HOT 3
- IE9 compatibility HOT 5
- disableHeight & disableWidth HOT 2
- requestAnimationFrame support HOT 1
- ReactDOMServer stops rendering on react-dimensions decorated components
- add LICENSE
- Initial render has window size HOT 6
- documentation issues
- get 0 for "this.props. containerHeight" HOT 2
- Describe how to use 2.0.0-alpha1 HOT 5
- 不兼容 ie内核的浏览器吗?
- Question about enzyme/mocha tests HOT 4
- use hoist-non-react-statics HOT 1
- I want to know the compatibility of this component HOT 1
- Looking for maintainers HOT 9
- Allow element type of wrapper to be configurable
- getWrappedInstance broken
- The component that asks for dimensions should be rendered even if the dimensions are nil
- Not working with redux connect
- Np
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-dimensions.