Deferred resolving doesn't seem to work about graphql-php HOT 15 CLOSED

Related to #320

from graphql-php.

@Jalle19 I took a look at this and you're right. The issue is that the promise is resolved immediately. I need to do some research. It might be that we need to introduce our own Deferred concept, like they have done in Webonyx implementation. I don't like the idea, but if it that's what it takes then we'll do that.

from graphql-php.

Any news on this?

from graphql-php.

@crisu83 do you have time to look into this?

from graphql-php.

or @hungneox

from graphql-php.

Confirm this issue. loadBuffered() is called everytime.

from graphql-php.

Guys, this issue is critical for production use. Do you have any suggestions? If you do not have time, tell me which way to dig?

from graphql-php.

This is literally the only reason I haven't swapped to this over my Youshido Fork.

from graphql-php.

@acelot I have my hands full right now with work, but the easiest way to look at it is to debug the deferred resolver test cases. I think that the main issue is related to how we're handling promises when executing them. CC @hungneox

from graphql-php.

Is there any thought to use https://github.com/overblog/dataloader-php
to solve the problem like almost everyone in node does?

from graphql-php.

I'm trying to adapt this library for my reactphp-project. I was able to perform a deferred request using lordthorzonus/php-dataloader. But for this I had to change the graphql-php code to support async calls. Because the existing executor have a race condition problem Execution::execute():

if ($data instanceof PromiseInterface) {
    $data->then(function ($resolvedData) use (&$data) {
        $data = $resolvedData;
    });
}

<...>

return new ExecutionResult($data, $context->getErrors());

In this section of the code, the $data variable will always be null and will throw an exception.
To add support for asynchronous calls, I suggest adding a new method promiseExecute which implements new PromisedExecutionInterface:

class Execution implements ExecutionInterface, PromisedExecutionInterface
{
    <...>

    public function promiseExecute(
        Schema $schema,
        DocumentNode $documentNode,
        $rootValue = null,
        $contextValue = null,
        array $variableValues = [],
        ?string $operationName = null,
        ?callable $fieldResolver = null,
        ?ErrorHandlerInterface $errorHandler = null
    ): PromiseInterface {
        <...>

        if ($data instanceof PromiseInterface) {
            return $data->then(function ($resolvedData) use ($context) {
                return new ExecutionResult($resolvedData, $context->getErrors());
            });
        }

        <...>

        return resolve(new ExecutionResult($data, $context->getErrors()));
    }

    <...>
}

I can provide PR, but I need help with tests.

from graphql-php.

@acelot PRs are more than welcome, I'll help you out with the tests!

from graphql-php.

@Jalle19 #345

from graphql-php.

@acelot is this issue resolved?

from graphql-php.

Yes, completely.

from graphql-php.