Comments (5)
Thanks for reporting and good job for noticing that ~2h after the relevant change was merged 👍
I think we just miss the relevant impl for nullable here:
diesel/diesel/src/expression/operators.rs
Line 749 in 6ef23bd
I think I would likely write something like that:
impl<T, DB> LikeIsAllowedForType<crate::sql_types::Nullable<T>> for DB
where
DB: Backend + LikeIsAllowedForType<T>,
{}
That also should cover Nullable<Binary>
for the postgres backend.
Mind sumitting a PR that adds this impl + adds a test so that we don't break it again?
from diesel.
https://github.com/diesel-rs/diesel/blob/master/diesel_tests/tests/filter.rs would be a good place for the test. I think the users table there already has a nullable text field.
from diesel.
Would be happy to :)
from diesel.
@weiznich I think I can figure out how to write the test, but can you point me to the workspace member library where the test should go?
from diesel.
Thank you!
from diesel.
Related Issues (20)
- Windows CI is failing to install postgres HOT 2
- Can not use .eq(Decimal_field + xxx) HOT 4
- Closing a sqlite connection does not clear the -wal and -shm file HOT 4
- Execute single-statement migrations without batch_execute HOT 6
- Linking error for diesel_cli in Alpine despite libraries being installed HOT 5
- Option field check in diesel_derives in incomplete
- oid caching leads to broken queries after schema changes HOT 2
- The diesel 2.1.5 version cannot close the tls connection HOT 7
- Diesel-Schema not supporting Postgres-SCHEMA HOT 1
- `skip_insertion` results in a compiler error HOT 4
- table with more than one primary_key can not use on_conflict().do_update() HOT 1
- Make empty changeset updates using `.optional()` , either ignore or bypass errors `QueryBuilderError` s.
- Rust-analyzer fails to autocomplete Match with diesel errors (Enum) HOT 4
- Migration Not Generating Correct Schema for Custom Types HOT 3
- Investigate new nightly warning about a soundness hole in the type system
- `diesel print-schema > foo.rs` fails without error message if database url not set HOT 1
- Using diesel CLI with `exclude_custom_type_definitions` has unexpected outcomes HOT 1
- [2.2.0 regression] mysqlclient-sys does not provide bundled bindings for libmysqlclient 21. Consider using the `buildtime_bindgen` feature or contribute bindings to the crate HOT 13
- `belonging_to().inner_join()` and `.select()` with two-item tuple causes build error on sqlite backend HOT 1
- derive(Queryable) doesn't work with a field of `Field` type HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from diesel.