Giter Club home page Giter Club logo

Comments (29)

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024 1

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024 1

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024 1

oops sorry here you go.
failed_transactions-swissquote.csv
Screenshot 2023-12-04 at 09 51 11

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024 1

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

If you can provide me with example exports I can take a look at it!

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024

Are these CSVs ok or do you need more examples?

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

Sorry, haven't had time to look at it yet. After a quick glance just now I think the finpension export will work, but I need more transactions for Swissquote (different kinds, for example buy/sell are missing).

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024

Ok, I’ll upload a more elaborate csv later today. No worries. Appreciate you taking the time to check it out! :)

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024

Heya, heres a more elaborate swissquote example.
swissquote_transaction-2.csv

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

This could work. When I have some time I will try and work this out!

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

I have added a Finpension converter here. Can you try and verify if it works for you? The file you provided is converted succesfully and as far as I can see all looks good.

Please let me know if you have any findings. If all is good, can you provide me with step-by-step instructions how to make a Finpension export (like here), so I can add it to the readme?

When I find some time later this week I will work on the Swissquote converter!

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

@mikaelheidrich I also added the Swissquote converter to the same branch.

Can you take a look at them and verify if they process your exports? Both CSV's you provided seem to be converted OK and are importable to Ghostfolio.

Can you also provide export instructions for Swissquote (as well as for Finpension), so I can add those to the manual? Thanks!

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

I had this same error on Yahoo Finance this morning, I believe this is because Yahoo Finance is rate limiting you because their api was requested too many times within the hour.

As for the discontinued ETF, it isn’t placed in the JSON which you import in Ghostfolio?

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

Okay, I will try and look into the Swissquote error later this week and get back to you when I find something!

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

Thanks for the instructions! I have added them to the readme file.

As to the issue you describe with Swissquote. I have run the export you provided in this thread (swissquote_transaction-2.csv) without any issue just now. Can you please check wether you still have issues at this time? If so, can you provide me with a (partial) export of the record(s) that give you an error? That way I can analyse the issue and get to a fix.

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

I don't see an attachment. Don't think that works when replying via email. Can you add them in this issue on GitHub?

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

They were records without an ISIN, so no wonder they break 😁

I have added them to the skip list. Can you verify one last time before I merge these changes?

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024

Hi Dick, exporter runs now with no crashing. So I have gone through three years of transactions and I have merged all the remainng troublesome exports from my broker into one csv.

sample-swissquote-export.csv

The following is noteworthy.

-VEUD Dividend is mis identified as veurl.as where as the VEUD buy or sell is correctly identified as VEUD.L
-Custody Fees should be identified as Fees
-ORFN is the discontinued ETF, I can enter those manually i think

  • in 2022 the sell transaction IAAA, CORP and IGIL throw a no result found as it seems to be looking for CHF instead of USD, other transactions exactly the same in other years of these same ETFs worked no problem.
  • WENS gets identified as WENS.AS in EUR instead of WENS in USD
  • VWRL dividend gets identified as WWRD.AS, Eur instead of USD.
  • ETH should be identified as Ethereum Crypto Currency

I could also be noted that, after deselecting wrong imports in Ghostfolio and subsequently deleting succesful transactions from the cvs and then re-runing the export tool, some of the faulty exports where then exported correctly. That is to say, trimming down the csv and reruning it sometimes fixed some of the faulty exports.

hope this helps,

Mikael

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

Thanks for your detailed analysis. I will try to take a look this weekend and come back to you.

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

@mikaelheidrich The file you attached seems to be empty

from export-to-ghostfolio.

mikaelheidrich avatar mikaelheidrich commented on August 17, 2024

strange, lets try this one:

sample-swissquote-export-merged.csv

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

I added custody fee support. Will now look at the file you sent and check your analysis.

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

@mikaelheidrich Did you manaually merge the files? The tool does not process is because the column count does not match. The header has 15 columns, but there are many rows with only 13 columns.

For now I have removed the 13 colums rows and then I can process the file. Will try again with 13 columns with changed header.

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

Pushed some more changes.

Regarding your analysis, my thoughts below:

  • VEUD is matched to VEUR.AS as that is the only match found while searching by ISIN (when you enter IE00B945VV12 in Yahoo Finance you only get VEUR.AS. The tool does not continue to look for another symbol because the currency matches (your dividend is paid in EUR and VEUR.AS is EUR.
  • Custody fees are added. Please check if the values are mapped correctly.
  • I see the records for IAAA, CORP, etc. have another currency attached in the row. This value wasn't used (it used currency from the last column). I have now added a control to use netAmountCurrency if present, otherwise currency. The tool now finds matches.
  • WENS now matches in USD
  • VRWL now matches in USD
  • There is no way for the tool to determine ETH is the cryptocurrency. Trying something with combining names (like ETH-USD) is probably going to break something somewhere else, though.

from export-to-ghostfolio.

dickwolff avatar dickwolff commented on August 17, 2024

Merged changes into main branch. If any issues persist, please open a new issue.

from export-to-ghostfolio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.