Giter Club home page Giter Club logo

Comments (8)

diasks2 avatar diasks2 commented on August 16, 2024

@airy - no test to catch this, but I got this error when running in production. Should we get the abbreviations based on the language that is passed to the initialization method?

from pragmatic_segmenter.

airy avatar airy commented on August 16, 2024

@diasks2, every language module (should) have it's own or the included common language's abbreviations. which language is it?

from pragmatic_segmenter.

diasks2 avatar diasks2 commented on August 16, 2024

I was able to create a failing spec: 63e619c

from pragmatic_segmenter.

airy avatar airy commented on August 16, 2024

gotcha!

cleaner trying to access abreviations as instance variable, https://github.com/diasks2/pragmatic_segmenter/blob/master/lib/pragmatic_segmenter/cleaner.rb#L65

those constants/variables are/must be provided by the language module.

from pragmatic_segmenter.

airy avatar airy commented on August 16, 2024

this should fix the exception but not to pass the test.

from pragmatic_segmenter.

diasks2 avatar diasks2 commented on August 16, 2024

Thanks...but the link above is a 404 for me. Could you try to commit it again?

from pragmatic_segmenter.

airy avatar airy commented on August 16, 2024

ops! here is it: https://github.com/airy/pragmatic_segmenter/commit/e5b07a5c002e118d75da1921b424ef1e61fd227a

from pragmatic_segmenter.

diasks2 avatar diasks2 commented on August 16, 2024

Thanks! Fixed: c10ff3b

from pragmatic_segmenter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.