Giter Club home page Giter Club logo

Comments (14)

jakob1379 avatar jakob1379 commented on July 26, 2024 2

@di-sukharev, just some context:

Tools like commitizen are widely used to make conventional commits for automating semantic versioning and changelogs. Currently, OC does not conform to conventional commits. You can find the specifications here.

The main issue a missing blank space between the first line describing header (type, scope, and subject) and the descriptive text.

from opencommit.

D4RKAR117 avatar D4RKAR117 commented on July 26, 2024 2

It goes beyond that, usually projects use the following package to lint their commits using git hooks (husky), if the AI follow the specs configured at commitlint.config.js/ts file, and as @jakob1379 said the specification of conventional commits. That way, many workflows that implement the commit linting can use opencommit without major problems

from opencommit.

di-sukharev avatar di-sukharev commented on July 26, 2024

you can do oc --amend and all other git commit flags are also passed to oc. Sorry, I dont get your first 2 points :0

from opencommit.

D4RKAR117 avatar D4RKAR117 commented on July 26, 2024

Yeah, by default some tools like monorepos use git scopes to automate releases of certain packages, so would be great that as @jakob1379 suggest, the AI uses conventional commits or any other git spec (like angular commits) or even custom specs to do their job, so tools that sues that spec don't fail, something like commitlint and that

from opencommit.

di-sukharev avatar di-sukharev commented on July 26, 2024

so you are saying that adding a blank space between header and description would solve the issue?

from opencommit.

dasheck0 avatar dasheck0 commented on July 26, 2024

+1 this. I maintain multiple projects with their respective commit message style. It is not always conventional commits sometimes just plain english (what I dislike. But this is a different discussion altogether). However, it would be great if OC recognizes this and creates messages according to the commit style that is already present. As far as I know one can send this is further context for GPT-3.5. I suppose that last n commits are sufficient as well, so that you don't have to send the while history for this to work.

from opencommit.

di-sukharev avatar di-sukharev commented on July 26, 2024

could anybody help me here please and make the PR? <3

from opencommit.

dasheck0 avatar dasheck0 commented on July 26, 2024

I can take a look it this. Not sure when I get to it. Probably this weekend

from opencommit.

sebastienfi avatar sebastienfi commented on July 26, 2024

+1 this. I maintain multiple projects with their respective commit message style. It is not always conventional commits sometimes just plain english (what I dislike. But this is a different discussion altogether). However, it would be great if OC recognizes this and creates messages according to the commit style that is already present. As far as I know one can send this is further context for GPT-3.5. I suppose that last n commits are sufficient as well, so that you don't have to send the while history for this to work.

I'd rather have a config to define the style, because previous commit messages might be flawed. Yet enhancing prompt with previously correct commit messages could be a nice option.

from opencommit.

sebastienfi avatar sebastienfi commented on July 26, 2024

I'm working on this, I will submit a PR soon.

from opencommit.

sebastienfi avatar sebastienfi commented on July 26, 2024

@D4RKAR117 @jakob1379 @dasheck0 Could you please review the PR and provide feedback?

from opencommit.

github-actions avatar github-actions commented on July 26, 2024

Stale issue message

from opencommit.

di-sukharev avatar di-sukharev commented on July 26, 2024

@sebastienfi hi, are we done here or should i reopen?

from opencommit.

di-sukharev avatar di-sukharev commented on July 26, 2024

ok, i see <3

from opencommit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.