Giter Club home page Giter Club logo

Comments (14)

brandoncc avatar brandoncc commented on July 26, 2024 3

@maxence33 I think you are right, I was really surprised to hear that this buildpack had helped you with webp. Now that this is merged, You may not need webp in your apt file anymore.

@wilg @rjherrera @maxence33 I sincerely apologize for this taking so long. I just merged. Let me know if any of you experience any issues.

from heroku-buildpack-vips.

brandoncc avatar brandoncc commented on July 26, 2024 1

@wilg libvips/libvips#1825 was the issue.

I just pushed the updated buildpack. You should have webp and heif after your next deploy. If you would like to see how I did it, check out fd24031.

from heroku-buildpack-vips.

brandoncc avatar brandoncc commented on July 26, 2024 1

I had to revert the commit because ruby-vips was broken, I'll try to get this back into master today.

from heroku-buildpack-vips.

brandoncc avatar brandoncc commented on July 26, 2024 1

Hi @maxence33,

There is a PR which should fix libheif compatibility. I just haven't had time to test it. I'll get that done today and get back to you.

from heroku-buildpack-vips.

brandoncc avatar brandoncc commented on July 26, 2024

I think so, yes. I will work on that for you.

from heroku-buildpack-vips.

wilg avatar wilg commented on July 26, 2024

😍 Thanks so much!

from heroku-buildpack-vips.

brandoncc avatar brandoncc commented on July 26, 2024

I made an attempt at this, but vips doesn't want to compile with libheif-dev. I opened an issue on libvips, and I am hoping that I will be able to get this together for you soon.

from heroku-buildpack-vips.

wilg avatar wilg commented on July 26, 2024

Wow that's great, thanks! Do you mind linking the issue so I can follow along?

If you have a branch or something with only libwebp that's still enough to be super useful for me!

from heroku-buildpack-vips.

wilg avatar wilg commented on July 26, 2024

Awesome thank you so much!

from heroku-buildpack-vips.

rjherrera avatar rjherrera commented on July 26, 2024

hi @brandoncc thank you for the update!! I found myself needing the same for webp, any news on the support for those libraries?

from heroku-buildpack-vips.

brandoncc avatar brandoncc commented on July 26, 2024

I'm sorry for the delay! I worked on this some more today. I have everything compiling, and vips says it can open heif files, but when I try, it tells me that the file is not a known file format.

I have the work in a PR if anyone wants to try it in their application, but I don't believe it will work yet.

I opened another issue on the libvips repo, and hope John can help me get this working. libvips/libvips#1945

from heroku-buildpack-vips.

maxence33 avatar maxence33 commented on July 26, 2024

Hello all,
I have this buildpack in my Heroku app and everything was working fine until a recent deploy (I don't deploy often so can't tell when it started to break)
With the following error :

E: Unable to locate package libheif

! Push rejected, failed to compile Apt app.

! Push failed

I have not changed stack, and am still on 18.
Also my Apt file is as below :

webp
libglib2.0-0
libglib2.0-dev
libpoppler-glib8
libheif

and my buildpacks order :

https://github.com/mojodna/heroku-buildpack-jemalloc.git
https://github.com/brandoncc/heroku-buildpack-vips
https://buildpack-registry.s3.amazonaws.com/buildpacks/heroku-community/apt.tgz
heroku/ruby

I had done this Aptfile a long time ago and it is stlightly different than the one recommended (mostly no Webp or libheif reference)
Should I match the recommended Buildpack without losing Webp support ?

from heroku-buildpack-vips.

maxence33 avatar maxence33 commented on July 26, 2024

Fantastic. Yet Webp used to work with this buildpack in the past. (I think both with ImageMagick and Vips through ROR gems Shrine and ImageProcessing)
Any reason why this Issue was raised first place ?

(I mean Libheif and Webp from my Apt file were kinda working ?)
(Sorry I am not very at ease with buildpacks)

from heroku-buildpack-vips.

maxence33 avatar maxence33 commented on July 26, 2024

Oh I think I am kinda mixing Libheif and Webp.
Probably Webp from my Apt file still build correctly.

I may just remove Libheif for now, while the PR is up, as I don't think I actually need handling HEIF and AVIF files.

from heroku-buildpack-vips.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.