Giter Club home page Giter Club logo

Comments (3)

DhrBaksteen avatar DhrBaksteen commented on August 20, 2024

I think you're using the OPL3 class directly? When I wrote OPL3.cpp I intended it as a base for the OPL3Duo class, so I have not fully tested it stand alone.

  1. The setChipRegister for the OPL3 class was indeed missing and I have staged it locally for the upcoming update as
void OPL3::setChipRegister(short reg, byte value) {
	chipRegisters[getChipRegisterOffset(reg)] = value;
	write(reg >> 8, reg & 0xFF, value);
}
  1. For the setChannelRegister and setOperatorRegister of the OPL3 class I see I completely messed up here cause indeed it should not be (channel >> 8) & 0x01! It can be something like byte bank = (channel / CHANNELS_PER_BANK); as in the OPL3Duo class.

from arduinoopl2.

jonkerj avatar jonkerj commented on August 20, 2024

Yes indeed. I am using OPL3 directly. I will try the suggestions, was already peeking at the OPL3Duo code, where they seem more appropriate.

from arduinoopl2.

jonkerj avatar jonkerj commented on August 20, 2024

Yes, that works. I'll PR it for good measure.

from arduinoopl2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.