[C4GT] Network-Score: Add tests for 'MessageIdAlreadyExists' about cord HOT 7 CLOSED

Hey @amarts , In this project we have to make a test which asserts that message already exists and we need to add this test in to network-score folder and that should pass three tests , namely Build , Cargo and test mentioned in the Readme.md File , Have I got the right idea ? let me know if I am wrong otherwise Tell me so i start to working on it
Thank you

from cord.

@zeel991 Yes you have to add new test method in tests.rs which,
asserts the error code MessageIdAlreadyExists for all methods used in lib.rs.
Example: MessageIdAlreadyExists is being returned from methods revise_rating, register_rating etc.
Then call cargo test -p pallet-network-score. If it passes proceed with pre PR checks as mentioned in README.

from cord.

Ok , I'll start working on this issue as the next thing .Thank you

from cord.

Hey @vatsa287 ,I have been trying to build cord in production mode using the command cargo build --production , but it is not working and giving error , It shows that unexpected argument '--production' found , my cargo version is 1.75.0 , I tried the command cargo build --release , which worked fine , what should I do , can you help solve the error ?

from cord.

@zeel991 Yes you can proceed to with cargo build --release.

@amarts Maybe I'll update README to reflect change from --production to --release.

from cord.

Thank you so much @vatsa287 , I wanted to share that while running the clippy command ( cargo clippy --all --no-deps --all-targets --features=runtime-benchmarks -- -D warnings) , I found a few errors , one was

I've currently just commented it out , but would appreciate your advice on this ,

After commenting , I got this Error and tried very hard but couldn't fix it

Can you Please Guide me as I have written the test but these issues wont let me get my PR merged .
Thank you

from cord.

@zeel991 Interesting open the PR, lets check with GH tests.

from cord.