pre-commit hooks is not working as expected about python-license-check HOT 3 CLOSED

I solved this by adding the flag pass_filenames: false

- repo: https://github.com/dhatim/python-license-check
  rev: '0.6.2'
  hooks:
  - id: liccheck
    pass_filenames: false

from python-license-check.

I solved this by adding the flag pass_filenames: false

- repo: https://github.com/dhatim/python-license-check
  rev: '0.6.2'
  hooks:
  - id: liccheck
    pass_filenames: false

I have strategy file as name strategy.ini and liccheck.ini so it need to see them. Unfortunately liccheck can't. I also tried configure pyproject.toml :

[tool.liccheck]
authorized_licenses = [
    "BSD",
    "new bsd",
    "bsd license",
    "new bsd license",
    "simplified bsd",
    "apache",
    "apache 2.0",
    "apache software license",
    "gnu lgpl",
    "lgpl with exceptions or zpl",
    "isc license",
    "isc license (iscl)",
    "mit",
    "mit license",
    "python software foundation license",
    "zpl 2.1",
    "Apache Software",
    "GNU Library or Lesser General Public License (LGPL)",
    "Mozilla Public License 2.0 (MPL 2.0)",
    "Historical Permission Notice and Disclaimer (HPND)",
    "Python Software Foundation",
    "3-Clause BSD",
    "Apache-2.0",
]
unauthorized_licenses = [
    "gpl v3"
]
[tool.liccheck.authorized_packages]
test = "1.0.0"

both give us error.

$ pre-commit run --all-files liccheck
Run Python License Checker...............................................Failed
- hook id: liccheck
- exit code: 1

Need to either configure pyproject.toml or provide an existing strategy file

from python-license-check.

As @commonlawfeature pointed out, it's also working for me with the pass_filenames: false

Another tweak I had to do was use language: system, since this hook requires to be running in the virtual env that contains all the libraries

  - repo: https://github.com/dhatim/python-license-check
    rev: master
    hooks:
    - id: liccheck
      pass_filenames: false
      language: system

pass_filenames: false should be set in the .pre-commit-hooks.yaml file contained in this repo

If we don't set that flag, pre-commit will provide the liccheck entry point with any of the files filtered by files: ^(.*requirements.*\.txt|setup\.cfg|setup\.py|pyproject\.toml|liccheck\.ini)$

Thus, it will try to call liccheck requirements.txt setup.py if you have these 2 files in the repository but liccheck isn't setup to work with positional argument like that so that's why it fails with liccheck: error: unrecognized arguments: pyproject.toml requirements.txt setup.cfg

I'll open a PR shortly with that fix

from python-license-check.