Comments (7)
eribertomota
commented on July 20, 2024
1
Working fine now!
Uploaded to Debian.
Thank you very much.
from detox.
dharple
commented on July 20, 2024
Thanks for the heads up @eribertomota. I'm looking in to this.
from detox.
eribertomota
commented on July 20, 2024
Thanks! Can you release a new version? Debian will release version 11 soon and I have few days to send new uploads.
from detox.
dharple
commented on July 20, 2024
Took me forever to remember how to do it all, but, yeah, I'm tagging v1.3.1 now.
Interestingly enough, the bug showed up in my extremely simple tests. The tests literally just run a dry-run against a bunch of files and then diffs the output between versions.
The "" and "" in the filenames below, generated by v1.3.0, is the bug.
The terminal doesn't render them, but they show up inside of less.
checking: lower
1c1
< detox 1.3.0
---
> detox 1.3.1
43,52c43,52
< sample_test_bed/iso8859/<C3>_capital_ae
< sample_test_bed/iso8859/<C2>_copy
< sample_test_bed/iso8859/<C2>_ellipsis
< sample_test_bed/iso8859/<C2>_reg
< sample_test_bed/iso8859/<C3><C3><C3>_thin_<C2><C3><C3><C3>_south
< sample_test_bed/iso8859/<C3>_latin_small_letter_y_with_diaeresis
< sample_test_bed/iso8859/<C2>_yen
< sample_test_bed/iso8859/<C2>_trade_mark
< sample_test_bed/iso8859/<C2>_pound
< sample_test_bed/iso8859/<C2>_cent
---
> sample_test_bed/iso8859/®_reg
> sample_test_bed/iso8859/¢_cent
> sample_test_bed/iso8859/Æ_capital_ae
> sample_test_bed/iso8859/<U+0085>_ellipsis
> sample_test_bed/iso8859/ÐÏÑ_thin_<U+008A>ØÙÞ_south
> sample_test_bed/iso8859/<U+0099>_trade_mark
> sample_test_bed/iso8859/ÿ_latin_small_letter_y_with_diaeresis
> sample_test_bed/iso8859/¥_yen
> sample_test_bed/iso8859/©_copy
> sample_test_bed/iso8859/£_pound
54,63c54,63
< sample_test_bed/unicode/<C3><C2>_reg
< sample_test_bed/unicode/<C3><C2>_copy
< sample_test_bed/unicode/<C3><C2>_trade_mark
< sample_test_bed/unicode/<C3><C2>_cent
< sample_test_bed/unicode/<C3><C2>_latin_small_letter_y_with_diaeresis
< sample_test_bed/unicode/<C3><C2>_yen
< sample_test_bed/unicode/<C3><C2>_ellipsis
< sample_test_bed/unicode/<C3><C2><C3><C2><C3><C2>_thin_<C3><C2><C3><C2><C3><C2><C3><C2>_south
< sample_test_bed/unicode/<C3><C2>_pound
< sample_test_bed/unicode/<C3><C2>_capital_ae
---
> sample_test_bed/unicode/Â¥_yen
> sample_test_bed/unicode/Ã<U+0086>_capital_ae
> sample_test_bed/unicode/¢_cent
> sample_test_bed/unicode/Ã<U+0090>Ã<U+008F>Ã<U+0091>_thin_Â<U+008A>Ã<U+0098>Ã<U+0099>Ã<U+009E>_south
> sample_test_bed/unicode/£_pound
> sample_test_bed/unicode/®_reg
> sample_test_bed/unicode/©_copy
> sample_test_bed/unicode/ÿ_latin_small_letter_y_with_diaeresis
> sample_test_bed/unicode/Â<U+0099>_trade_mark
> sample_test_bed/unicode/Â<U+0085>_ellipsis
from detox.
dharple
commented on July 20, 2024
Hey Eriberto,
v1.3.1 is tagged and ready for review. Let me know if you encounter any problems.
Doug
from detox.
eribertomota
commented on July 20, 2024
Em sáb., 30 de jan. de 2021 às 19:50, Doug Harple <[email protected]>
escreveu:
Hey Eriberto,
v1.3.1 is tagged and ready for review. Let me know if you encounter any
problems.
Doug
I am a bit confused. The detox builds fine but I can't see a difference
between results created by 1.3.0 and 1.3.1. Both versions generated
'm'$'\207'' '$'\204''.txt' for me. Can you clarify? Sorry for the confusion.
Thanks in advance.
from detox.
dharple
commented on July 20, 2024
Eriberto,
You're absolutely correct. There were at least two off-by-one errors in the UTF-8 translation. It is working correctly for me now, using the test file "mÉ Æ.txt". If I have no translation for Unicode values 0x00c9 or 0x00c6, nothing happens to them.
So, using the test table and detoxrc from the original Debian bug, I get:
$ rm m*.txt ; touch "mÉ Æ.txt" ; ~/work/detox/src/detox -vs gnu *.txt
Scanning: mÉ Æ.txt
mÉ Æ.txt -> mÉ_Æ.txt
from detox.
Related Issues (20)
- utf_8 filter converts spaces to underscores HOT 1
- Compiling error on windows 10 HOT 4
- Im not sure why the man pages are confusing me so much HOT 3
- simple example for converting an ofending char to custom string HOT 1
- Compilation under Windows with MSYS2 fails
- Value too large for defined data type HOT 6
- configure.ac: warnings with autoconf >= 2.70 HOT 3
- Released tarballs are missing CHANGELOG and LICENSE and THANKS Files HOT 3
- Is there a way to pass a custom TBL file to a filter, e.g. `safe` HOT 3
- inline-detox – segmentation fault
- Is `utf_8-only` doing more stuff (converting e.g. brackets) than it is needed? HOT 1
- How can I delete certain characters instead of replacing them? HOT 4
- Not replacing space eats the next character HOT 1
- Operate on std-in list of names and generate list out names on std-out HOT 1
- Compiling under CircleCI is broken HOT 1
- How to ignore Icon␍ macOS files? HOT 3
- Ignore folders? HOT 3
- double free or corruption (out) when using custom sequence
- Is it possible to replace characters and remove punctuation (i.e. parentheses, braces etc.) in one detox command? HOT 1
- Please provide a way to retain German Umlaute ÄÜÖäüö HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from detox.