add multidelete support. about ristretto HOT 4 CLOSED

I would be happy to implement this if you need an extra pair of hands.

from ristretto.

@momilo Feel free to take it.

from ristretto.

@balajijinnah @momilo As I mentioned to @manishrjain there will be no performance gains in adding a MultiDelete function until we move from a sharded map implementation (if we do). Based on experiments at https://github.com/karlmcguire/stress we've found that the fastest overall solution is the one we're currently using: a sharded hashmap and calling Del on each shard.

Therefore, for MultiDelete the fastest solution is indeed the simplest most idiomatic one:

func (m *Map) MultiDel(keys []uint64) {
	for _, key := range keys {
		m.shards[key&shardMask].Del(key)
	}
}

This issue should be on hold until we change the underlying hashmap. For now, just call Del multiple times in a for loop.

from ristretto.

Github issues have been deprecated.
This issue has been moved to discuss. You can follow the conversation there and also subscribe to updates by changing your notification preferences.

from ristretto.