Giter Club home page Giter Club logo

Comments (5)

stephane-martin avatar stephane-martin commented on May 17, 2024

Run twice

fmt.Println("testBadger called")
opts := badger.DefaultOptions
dir := "/Users/stef/tmp"
opts.Dir = dir
opts.ValueDir = dir
b, err := badger.NewKV(&opts)
if err != nil {
    fmt.Println("error")
    return
}
key := []byte("key")
item := badger.KVItem{}
b.Get(key, &item)
if item.Value() == nil {
    fmt.Println("non existent key")
    val := []byte("ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789FOOBARZOGZOG")
    b.Set(key, val)
    fmt.Println("key value has been inserted")
    b.Get(key, &item)
    fmt.Println("getting the value")
    fmt.Println(string(item.Value()))
    b.Delete(key)
    fmt.Println("key value has been deleted")
    fmt.Println("getting the value again")
    b.Get(key, &item)
    fmt.Println(item.Value())
} else {
    fmt.Println("key exists")
    fmt.Println(string(item.Value()))
}
b.Close()

from badger.

pawanrawal avatar pawanrawal commented on May 17, 2024

Hi @stephane-martin, thanks for the bug report. I have submitted a fix and this shouldn't be a problem anymore.

from badger.

stephane-martin avatar stephane-martin commented on May 17, 2024

The fix works, thanks!

from badger.

manishrjain avatar manishrjain commented on May 17, 2024

I'm actually not sure why this is the case. If you close cleanly, then Badger should not have to replay the value log, which means the delete markers in value log won't be required.

There's something else going on here, which is causing value log to be replayed even when Badger is closed properly. We should look into why that is happening.

from badger.

pawanrawal avatar pawanrawal commented on May 17, 2024

We update valuePointer even if Fid and Offset are 0 and it has length and we replay from end of last entry instead of start so we don't need to have delete markers anymore.

from badger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.