Slice bounds out of range error about badger HOT 7 CLOSED

Any idea how is this badger related, @pawanrawal?

from badger.

I am sure that it is related to badger because I couldn't reproduce it on master. I suspect somehow incomplete data for the key is getting written on disk. When we try to read it back in Dgraph and parse it we get out of bounds error. I have set syncWrites to true.

There could also be something wrong with how its used within Dgraph https://github.com/dgraph-io/dgraph/blob/badger/worker/backup.go#L258.

from badger.

This is caused by the /head/ key. While taking backup we go through all keys and try to parse them. Since this key wasn't written from Dgraph we cant parse it and hence get this error. This should ideally not be returned to the user during iteration.

from badger.

from badger.

Sure, should we write the /head/ key to some other file separate from the .sst files? That way we can avoid this special check in iterator functions.

from badger.

No, it has to go along with the .sst files. That's the only way to know how far LSM tree has reached.

Update: You can also do some optimization, so if we are already past the /head/ key, we just store that and don't keep on comparing the keys.

from badger.

This should now be fixed.

from badger.