Giter Club home page Giter Club logo

Comments (4)

PeterKraus avatar PeterKraus commented on August 23, 2024

Yes, the Pydantic parser for the schema is really not useful in figuring out where the problem is. I need to make that more user-friendly for yadg-5.0. There shouldn't be any problem using schema_version: "4.0.0" with the newest version of yadg for now, apart from getting one warning about out-of-date schema.

There are several breaking changes between the DataSchema-4.0 and DataSchema-4.2. Let me know if the docs are not helpful enough to make the switch between the two schemas.

from yadg.

JAC28 avatar JAC28 commented on August 23, 2024

Thank you for your quick reply, I will try to work with 4.0.0

FYI:
I got

Eranges.append(E_range_max - E_range_min)
TypeError: unsupported operand type(s) for -: 'str' and 'str'

in eclabmpt.py l. 317 due to my (german) decimal seperator "," which was not parsed properly. I fixed it by addding
float(el.get("E_range_max", float("inf")).replace(',','.')) to l. 315 and 316 - however, there might be a more elegant way. :) Propbably, this problem might araise with at other places as well.

My .mpt file contains 154 for the value of I_range which results in

ValueError: element '154' for parameter 'I_range' not understood.

in eclabtechniques.py in l. 1039. I was not able to reconstruct why my Biologic exports this value and will further investigate.

from yadg.

PeterKraus avatar PeterKraus commented on August 23, 2024

I didn't know mpt files were localised. That's a bug. Could you please upload the mpt (and ideally the mpr, if you have it) in a new issue? I'll have to think of a solution without having to replace every float() call, and it would be good to have a test file. It should also be possible to figure out the appropriate I_range.

I made a note for myself that the DataSchema validation could be improved for yadg-5.0, and I wouldn't mind closing this one in favour of #94 if that's OK with you.

from yadg.

JAC28 avatar JAC28 commented on August 23, 2024

Yes, closing this issue ist fine. I will create .mpr and .mpt files with my equipment that I can share and open a new issue for potential localisation problems.

from yadg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.