sfh=1, updating both sf_start and tage via Prospector about python-fsps HOT 8 CLOSED

Thanks! It looks to me like this is probably more a prospector issue than an fsps one, since the looping is happening there, and the implementation here looks sensible. @bd-j will have a better sense, but it might be worth moving this issue over there!

from python-fsps.

Yes this is probably better as a prospector issue though python-fsps could be set up to only run check_params() before or within the call to _compute_csp(). In practice I've never run into this because I usually don't use sf_start; I think sf_start>0 is perfectly degenerate with tage=tage-sf_start; sf_trunc=sf_trunc-sf_start; sf_start=0

from python-fsps.

Thank you both for your help. Perhaps it is a Prospector issue, however I couldn't figure out how to update the fsps parameters and call check_params() only after-the-fact.
In any case, I appreciate the advice for how to avoid the issue!

from python-fsps.

ah, right I guess there's no easy way to ensure the order that the parameters are updated won't trigger the error, without putting another identical check in prospector and reordering the update there. I think having StellarPopulation. _update_params() call self.params.check_params() might be the cleanest way to solve this issue.

from python-fsps.

Thanks both! This makes sense to me. Are there any other places where we should add a call to check_params or is that sufficient?

from python-fsps.

I think that’s the only place driver.update_* get called, so should be sufficient

from python-fsps.

perfect! Let's do it!

from python-fsps.

@k-a-webb this issue should be resolved by #187

from python-fsps.