Giter Club home page Giter Club logo

Comments (9)

drphilmarshall avatar drphilmarshall commented on July 24, 2024

I'm in favour of this switch. Corner is a good name ;-)

On Tuesday, September 15, 2015, Kyle Barbary [email protected]
wrote:

I've bugged Dan about this before on twitter. :)

There's considerable confusion caused by names in this module: The module
name is triangle, the pypi name is "triangle_plot," the repo name is
"triangle.py," and the main entry point within the package is corner().
Results of the confusion: #39
#39 and #28
#28.

I suggest renaming all of these to simply corner, which is miraculously
unclaimed on PyPI. You get:

  • pip install corner
  • from corner import corner or import corner; corner.corner(...)

(I'm not so set on the name, just the consistency.)

Two possible downsides:

  • There could still be conflicts with other PyPI packages if any of
    them provide a corner module or package (despite not being named
    "corner"). However, I didn't see any obvious candidates for this when
    searching "corner" on PyPI.
  • Dan might not want to rename the repo, since it is so popular. I
    would think github redirects would take care of this though?

Any thoughts on the color of this bikeshed?


Reply to this email directly or view it on GitHub
#59.

from corner.py.

dfm avatar dfm commented on July 24, 2024

It is no longer available 😉 https://pypi.python.org/pypi/corner; https://github.com/dfm/corner.py

from corner.py.

kbarbary avatar kbarbary commented on July 24, 2024

That was fast :) I suppose there's some reason you created a new repo instead of renaming? I think renaming would keep the forks/stars/watchers.

from corner.py.

dfm avatar dfm commented on July 24, 2024

Nope: I'm just dumb. Doing that now! I somehow forgot that GitHub does have redirects.

from corner.py.

kbarbary avatar kbarbary commented on July 24, 2024

Nice. My dreams have been fulfilled today.

from corner.py.

drphilmarshall avatar drphilmarshall commented on July 24, 2024

Mine too! :-)

Did you rename to corner or corner.py? I'd go for the former myself. Then-
does it make sense to rename the main def as "plot" in order to, you know,
make a cornerplot?

On Tuesday, September 15, 2015, Kyle Barbary [email protected]
wrote:

Nice. My dreams have been fulfilled today.


Reply to this email directly or view it on GitHub
#59 (comment).

from corner.py.

drphilmarshall avatar drphilmarshall commented on July 24, 2024

I guess adding a plot method that just calls corner is the better way to do
this though, to avoid breaking everyone's code even further :-)

On Tuesday, September 15, 2015, Phil Marshall [email protected]
wrote:

Mine too! :-)

Did you rename to corner or corner.py? I'd go for the former myself. Then-
does it make sense to rename the main def as "plot" in order to, you know,
make a cornerplot?

On Tuesday, September 15, 2015, Kyle Barbary <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

Nice. My dreams have been fulfilled today.


Reply to this email directly or view it on GitHub
#59 (comment).

from corner.py.

dfm avatar dfm commented on July 24, 2024

Well that took some git foo! But everything is properly migrated now. Thanks @kbarbary and @drphilmarshall. I have been wanting to do this!

You now install using:

pip install corner

and run:

import corner
corner.corner(...)

If you install triangle_plot it will continue working as a shim to corner.py but it throws a deprecation warning.

I don't like calling the function plot because I'd rather be able to do

from corner import corner

It would, of course, be even better to enable:

from corner.corner import corner as cornerplot

but who has time for that 😉

from corner.py.

drphilmarshall avatar drphilmarshall commented on July 24, 2024

:-)

Thanks a lot Dan, this is great.

I think I'll just munge my data into an array called "plot" and then do

import corner
corner(plot)

;-)

On Tue, Sep 15, 2015 at 3:37 PM, Dan Foreman-Mackey <
[email protected]> wrote:

Well that took some git foo! But everything is properly migrated now.
Thanks @kbarbary https://github.com/kbarbary and @drphilmarshall
https://github.com/drphilmarshall. I have been wanting to do this!

You now install using:

pip install corner

and run:

import corner
corner.corner(...)

If you install triangle_plot it will continue working as a shim to
corner.py but it throws a deprecation warning.

I don't like calling the function plot because I'd rather be able to do

from corner import corner

It would, of course, be even better to enable:

from corner.corner import corner as cornerplot

but who has time for that [image: 😉]


Reply to this email directly or view it on GitHub
#59 (comment).

from corner.py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.