Giter Club home page Giter Club logo

Comments (8)

luc-mercier avatar luc-mercier commented on August 27, 2024 1

Since dfx supports custom canisters, not just motoko, this is actually required.

from sdk.

nomeata avatar nomeata commented on August 27, 2024

Although need is a strong word. For now, Motoko doesn’t use this feature of the system, so one could argue that dfx doesn’t have to support it either yet. Definitely not pressing.

from sdk.

nomeata avatar nomeata commented on August 27, 2024

Agreed. The same feature was requestd for hfx a few days ago (https://github.com/dfinity-lab/dfinity/pull/5452), so there is demand now :-)

from sdk.

crusso avatar crusso commented on August 27, 2024

An external user (Norton Wang) also requested it here:

https://forum.dfinity.org/t/canister-installation-arguments/1254

from sdk.

luc-mercier avatar luc-mercier commented on August 27, 2024

Agreed. The same feature was requestd for hfx a few days ago (dfinity-lab/dfinity#5452), so there is demand now :-)

I wonder whether the 2 requests were somehow linked :)

from sdk.

nomeata avatar nomeata commented on August 27, 2024

I wonder whether the 2 requests were somehow linked :)

No way!

from sdk.

chenyan-dfinity avatar chenyan-dfinity commented on August 27, 2024

#1038 works for single canister install.

I want to discuss how to extend this to install --all and deploy. I can think of two options but none are perfect:

  • Ignore canisters that requires install arguments in install --all and deploy
  • Have a field in dfx.json to specify the arguments

With this feature, we are starting to have one-to-many mapping from wasm module to canisters, e.g., I can create several counter canisters with different initial values:

dfx canister install counter '(0)'
dfx canister install counter '(1)'
dfx canister install counter '(2)'

And I should get three canister ids associated with the counter module. How does dfx manage this mapping?

For my PR, I will just handle the single canister install with only one canister id case, and let the team decide how to support the more general case. WDYT?

from sdk.

p-shahi avatar p-shahi commented on August 27, 2024

part of this is done but the second half should be addressed with #1692

from sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.