Dark theme elements are broken about devtoys HOT 10 CLOSED

Hi,

Thanks for reporting this issue. I haven't encountered them yet.
I have a few questions that would help me to figure out what's going on:

1. You mentioned that you're using Windows 11, but the screenshot doesn't have Mica, neither rounded corner on the window. Are you running Windows 11 in a Virtual Machine without graphic acceleration?
2. Does the issue still happen after restarting DevToys?
3. Does the issue still happen after restarting Windows?
4. Regarding the error message in TextDiff, what is the font selected in the Settings?
   

Thank you in advance for your answers. :)

from devtoys.

1. You mentioned that you're using Windows 11, but the screenshot doesn't have Mica, neither rounded corner on the window. Are you running Windows 11 in a Virtual Machine without graphic acceleration?

The system is installed on real hardware and non full-screen apps have rounded corners. The graphics driver is also installed and works without errors.

2. Does the issue still happen after restarting DevToys?

Yes, the issue persists.

3. Does the issue still happen after restarting Windows?

Yes, the issue persists.

4. Regarding the error message in TextDiff, what is the font selected in the Settings?

The selected font is Cascadia Mono.

from devtoys.

Sounds good, thank you very much. :)

I have the same Windows build than you and I cannot reproduce the issue. Still, I will try to investigate it.

from devtoys.

Think I found the root of the issue. If the system theme is light, the bug appears. If the system theme is dark, the app displays correctly.

from devtoys.

Very good catch! I got a repro thanks to this information :D

So here are the repro steps:

1. Put Windows in Light mode.
2. Start DevToys.
3. Put Windows in Dark mode.

Note that the issue doesn't reproduce when manually changing the app theme in the DevToys settings.

Thank you so much! I will try to investigate it tonight. :)

from devtoys.

@veler, unfortunately, the bug is still in the new version. In addition, something happened to the layout and in the Russian localization the language selection item is larger than it should be. This is not a translation bug, because in the previous version with the same strings it was displayed correctly.

from devtoys.

Hi,
That is quite odd. I cannot reproduce the issue with the dark theme anymore.
Are you on version 0.6.6.0, like here?

I will take a look at it for the Russian language.
Thank you for your patience and feedback. :)

from devtoys.

Are you on version 0.6.6.0, like here?

Yes. I updated this morning from the Microsoft Store and the theme looks the same as the previous version.

from devtoys.

Thank you.

I just played with Windows settings a bit and can reproduce it with this custom configuration:

I will look at it again ASAP. Thanks again for reporting it. :)

from devtoys.

@VladimirKosolapov , I think I have a proper fix for the dark theme now. I will commit it soon.

For the issue where the ComboBox appears below the title of the setting: it is by design, to avoid ending up with a UI like this:

Instead, we prefer having the following:

In the update we shipped at the beginning of the week, we updated the layout by increasing these margins here in order to be more compliant Windows 11 guideline:

By design, when the UI get smaller, the ComboBox will go below the Title and Description of the setting when the [Size of ComboBox] > [1/3 the Setting size].

In the screenshot you shared, the ComboBox is indeed larger than 1/3 of the total width of the setting control.

In conclusion, the reason why you see a difference if because we changed the margins around the setting control, and now the setting control enters in a compact state depending on the length of the text in the ComboBox. It is the expected behavior. :)

from devtoys.