Giter Club home page Giter Club logo

Comments (6)

allburov avatar allburov commented on July 17, 2024

Easy way is require dohq-artifactory<1 for python < 3.4, of course.

from artifactory.

allburov avatar allburov commented on July 17, 2024

PEP 427 The Wheel Binary Package Format 1.0 says that filename use {python tag} - language implementation and version tag, E.g. 'py27', 'py2', 'py3'.

We could upload py35,py36,py37 wheels to pypi, but this way is too hard for supporting, imho. For a new python version we need to do some work.

So, I suggest support python>3.4 for versions after 1.0.1 and add python_requires to setup.py

from artifactory.

georgek avatar georgek commented on July 17, 2024

I say just drop support. It relies on a backport of pathlib that is unmaintained. Are you going to backport fixes to the last version of this library for 3.4? Probably not.

If anyone really wants to install the old versions for Python<=3.4 then they can pin their dependency to the last one that works.

If support is to be dropped after 1.0.0 then a deprecation warning could be added to 1.0.0 when imported with Python<=3.4.

from artifactory.

cowlinator avatar cowlinator commented on July 17, 2024

It will be cool if old versions of library will be available for python <=3.4
The way I interpret this is that old version implies zero backporting, zero maintenance, forever.

I support this idea. We don't want to force every single developer to have to individually re-discover which legacy version of dohq-artifactory works with their legacy version of python. Instead of each and every one of them pinning their dependency, how about we do it for them, one time, forever?

from artifactory.

georgek avatar georgek commented on July 17, 2024

Sure, if you can figure out a way to do that. But I don't think there is a way without having them pin their dependencies. You could generate the py35,py36,py37 wheels but then you'll have to keep making new ones for py38 etc. Is it really worth it to help people who should be upgrading their old version of Python anyway?

from artifactory.

cowlinator avatar cowlinator commented on July 17, 2024

Yes.

from artifactory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.