Giter Club home page Giter Club logo

Comments (5)

Pzixel avatar Pzixel commented on July 3, 2024

Ping? I can try adding this myself if you're agreed that it's useful to reexport generated types

from eth-sdk.

krzkaczor avatar krzkaczor commented on July 3, 2024

Hey @Pzixel!

Yes, this looks definitely like an important feature but I am not sure what exactly causes the problem. Structs should be exported in a code that TypeChain generates. You might just need a different import path to get them. Have you tried that?

from eth-sdk.

Pzixel avatar Pzixel commented on July 3, 2024

Hi!

Sorry, I'm not following which path you mean. I don't see any typechain artifacts in my eth-sdk-enabled project.

from eth-sdk.

Pzixel avatar Pzixel commented on July 3, 2024

Hi. Ping? I think this is quite crucial. I think I just might fix this, but I'm confused by you saying it already should work.

Could you please take a look on example I provide? Where can we find these types? If we look at eth-sdk-client we'll see

import { providers, Signer } from 'ethers';
import * as types from './types';
export declare function getContract(address: string, abi: object, defaultSignerOrProvider: Signer | providers.Provider): any;
export declare type MainnetSdk = ReturnType<typeof getMainnetSdk>;

So we dive into types that gives

import type * as mainnet from "./mainnet";
export type { mainnet };
export * as factories from "./factories";
export type { UniswapV3 } from "./mainnet/UniswapV3";
export { UniswapV3__factory } from "./factories/mainnet/UniswapV3__factory";

And this is it. As you can see only UniswapV3 type gets exported, inner structs remain private since they aren't reexported.

from eth-sdk.

Pzixel avatar Pzixel commented on July 3, 2024

I've just took a look and it looks like typechain isn't giving any names to such types. So I might start from there and then return here. You see even if typechain was properly generating intermediate structs they wouldn't be accessible since they aren't reexported

from eth-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.