Giter Club home page Giter Club logo

Comments (5)

Raven-002 avatar Raven-002 commented on August 21, 2024 4

After viewing the code, it seems as if there is no simple fix for it.

What cause the issue

The issue is that this feature (#944) is done as a hack, which causes the unwanted behavior.

It defines the final versions of letters the same way capital letters are defined.

What is a final letter?

For context: final letters are used only in end of words, unlike capital letters, which have a lot of use cases, and most notably capital first letter of a sentence.

possible fix

In order to fix the issue with the autocorrect, we will need to make it language dependent. From my quick look, it will require refactoring some code.

My suggestion

I suggest reverting the merge as it breaks the layout. In Hebrew, we are already used to the final letters being separate keys and not a shifted version, especially since most letters don't have one. The behavior introduced in the merge is unexpected and causes an unwanted behavior consistently, requiring the user to disable autocorrect globally.

If the feature is something anyone still wants, they can reopen the merge request and fix this issue, making sure it does not break the layout.

from thumb-key.

avishayshay avatar avishayshay commented on August 21, 2024

Yea this is very annoying.
please fix this.
There is no capitalization in Hebrew.

from thumb-key.

dessalines avatar dessalines commented on August 21, 2024

PRs welcome. I don't speak Hebrews, so I'll re-open should someone want to work on this.

from thumb-key.

dessalines avatar dessalines commented on August 21, 2024

Gotcha, I'll revert that PR then now.

from thumb-key.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.