Comments (5)
After viewing the code, it seems as if there is no simple fix for it.
What cause the issue
The issue is that this feature (#944) is done as a hack, which causes the unwanted behavior.
It defines the final versions of letters the same way capital letters are defined.
What is a final letter?
For context: final letters are used only in end of words, unlike capital letters, which have a lot of use cases, and most notably capital first letter of a sentence.
possible fix
In order to fix the issue with the autocorrect, we will need to make it language dependent. From my quick look, it will require refactoring some code.
My suggestion
I suggest reverting the merge as it breaks the layout. In Hebrew, we are already used to the final letters being separate keys and not a shifted version, especially since most letters don't have one. The behavior introduced in the merge is unexpected and causes an unwanted behavior consistently, requiring the user to disable autocorrect globally.
If the feature is something anyone still wants, they can reopen the merge request and fix this issue, making sure it does not break the layout.
from thumb-key.
Yea this is very annoying.
please fix this.
There is no capitalization in Hebrew.
from thumb-key.
PRs welcome. I don't speak Hebrews, so I'll re-open should someone want to work on this.
from thumb-key.
Gotcha, I'll revert that PR then now.
from thumb-key.
Related Issues (20)
- Layout Request: QwertEase (QWERTY x MessagEase hybrid)
- Typing first PIN number results in disappearing Thumb-key HOT 3
- Spacebar multitaps and line break HOT 3
- Add colon to swipe n-right-down [deutsch thumb-key] HOT 1
- Add quotation mark to swipe s-left-top [deutsch thumb-key] HOT 4
- Add descriptions to settings HOT 3
- Can't switch language when external keyboard connected HOT 1
- Vibrate on spacebar swipe
- Messagease circle gesture not functioning HOT 4
- Dependency Dashboard
- Circular drag action issue. HOT 17
- Vibration on tap stopped to work after update HOT 12
- Drag-and-return gesture depends on where the gesture ends instead of where it begins HOT 4
- writing problem while writing in japanese HOT 2
- [FRTypeSplit] spacebar should be switch with backspace HOT 1
- Upward swipes sometimes don't register HOT 2
- add en-dash and em-dash to english layouts HOT 1
- cant move to a new line on discord when the return key is pressed HOT 1
- Left/right offset - similar to bottom offset HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thumb-key.