Giter Club home page Giter Club logo

Comments (9)

andyboyd avatar andyboyd commented on June 12, 2024

@maebeam , any input on this? Would be good to know if this behaviour is expected, because it's pretty breaking right now for us.

from identity.

maebeam avatar maebeam commented on June 12, 2024

Sorry I missed this, for some reason my notifications were misconfigured.

Safari expires all javascript cookies after one week. If the cookie is expired we need the user to visit identity and click a button so we can store the cookie for another week. It sounds like we may need a special case where we use localStorage for Safari webviews embedded in apps

from identity.

maebeam avatar maebeam commented on June 12, 2024

Should be as simple as changing this function:

  mustUseStorageAccess(): boolean {
    return typeof document.hasStorageAccess === 'function' && !this.globalVars.webview;
  }

from identity.

maebeam avatar maebeam commented on June 12, 2024

Give that a try locally and either submit a PR or I can make the change for you

from identity.

andyboyd avatar andyboyd commented on June 12, 2024

I can give it a try locally, but if I understand correctly, I'll not be able to know if it's worked for a week? I think I'd prefer if you just made the change if that's ok, we've got actual real life users on our app now, so would be best if the fix got in as quickly as possible, and that'll probably happen faster with you making the changes.

I imagine after this fix is applied, user's will need to log out and back in to make sure identity stores things in the right place? If so, I'll need to put something into the app to make that happen when it needs to.

from identity.

andyboyd avatar andyboyd commented on June 12, 2024

Actually, I was able to verify locally that it works by changing the system time. I'll raise a PR now. Unfortunately it does seem that users will have to log out and back in again to avoid getting stuck, but I don't think that can be helped.

from identity.

andyboyd avatar andyboyd commented on June 12, 2024

I think this is probably resolved now, but I'd like to leave it open until I can verify that cookies are no longer expiring and locking users out if that's alright? Should know in a week or so.

from identity.

maebeam avatar maebeam commented on June 12, 2024

Sure, sounds good

from identity.

maebeam avatar maebeam commented on June 12, 2024

Closing since this seems resolved

from identity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.