Non deterministic post id creation about desmos HOT 4 CLOSED

This seems to happen also inside the handleMsgLike:

like := types.Like{
    ID:            xid.New().String(),
}

And inside handleMsgCreateSession

session := types.Session{
    ID:            xid.New().String(),
}

from desmos.

Why you think this ID should be deterministic?

from desmos.

@kwunyeung Let's consider the situation in which we have two different nodes, A and B.

The TX is processed by both nodes to update their respective statuses. While processing the MsgCreatePost message, this happens:

• on node A, the new post's ID assumes value X
• on node B, the new post's ID assumes value Y

After creating the post, the client then asks to both nodes for the list of all posts. What will he get are two different lists:

• from node A he will get a list containing a post with ID X
• from node B he will get a list containing a post with ID Y

What ID should it use when liking the post now? Should it use X or Y?

This obviously gets more and more complicated as new nodes are taken into consideration.

As far as I've understood the Handler is called on each node to update the local status, and thus the handler behavior should be 100% deterministic to make sure each node has the same status at each given point in time.

With this random ID generation we cannot guarantee it and thus we might run into conflicting statuses problems later in time.

from desmos.

Oops! My bad. Yes it has to be deterministic. Let's change it to an incremental ID like proposal ID and sequence before we get a solution on verifiable random number.

from desmos.