Giter Club home page Giter Club logo

Comments (8)

matthewlehner avatar matthewlehner commented on August 28, 2024 2

This is an incredible feature! Just tried it for the first time and was very surprised that it correctly updated our Dockerfile!

The one thing that this missed was a workflow for Github actions.

We're using Elixir with GitHub actions – it missed .github/workflows/*.yml with the https://github.com/erlef/setup-elixir action, like this:

      - name: Setup elixir
        uses: erlef/setup-elixir@v1
        with:
          elixir-version: 1.12.1 # Define the elixir version [required]
          otp-version: 24.0.2 # Define the OTP version [required]

I recognize that this is probably a tough one to support, but since you're supporting CircleCI, I thought I'd ask. If you've got the ability to add this, it'd be incredible.

from feedback.

halfbyte avatar halfbyte commented on August 28, 2024 1

@benedikt Good catch, we only update the Gemfile if it's using a simple version requirement. I'm working on a fix. Thanks for the early testing!

from feedback.

benedikt avatar benedikt commented on August 28, 2024

Fantastic new feature! 🔥 I'm really excited about this 👍

We're using both .ruby-version and the Gemfile to specify the Ruby version, but we're using a relaxed definition in the Gemfile like this:

ruby '~> 2.6.0'

The pull request to upgrade to Ruby 2.7.1 updated both the .ruby-version and the Gemfile.lock but didn't update the version specification in Gemfile.

from feedback.

Siilwyn avatar Siilwyn commented on August 28, 2024

Do you support the package.json Volta pinned fields?

from feedback.

rmehner avatar rmehner commented on August 28, 2024

Changed my .node-version by hand to the version depfu wanted to upgrade to (since I also had to adjust versions in the Dockerfiles) and depfu didn't autoclose its own PR because the version was already applied.

No biggie, just noticed. Nice feature all around! 👏

from feedback.

CorySanin avatar CorySanin commented on August 28, 2024

this pull request CorySanin/ffa-tycoon#13 is proposing I downgrade from the latest LTS version of node. Neat feature though.

edit: omg sorry for the thread bump 😬

from feedback.

viktorianer avatar viktorianer commented on August 28, 2024

Support for Dockerfile works, bot how abut related files like Dockerfile.dev and so on?

Also, if in package.json I have something like "node": "~18.x", I would like to have upgrade to "node": "~20.x" and not "node": "^20.6.1". The same for all other files and engines.

What about an option to upgrade only to the latest LTS version (Node.js 18.18.0 LTS), rather to the latest available version (Node.js 20.7.0 Current)?

from feedback.

bvogel avatar bvogel commented on August 28, 2024

Our dockerfiles aren't touched bc their naming does not fit the general naming schema. Ours are

  • base.Dockerfile
  • test.Dockerfile
  • Dockerfile.local

would it be feasible to add some kind of .depfurc-file to add these files to or should the glob be extended to *Dockerfile*?

from feedback.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.