Comments (5)
Got clarity internally that node16
is the plan for now:
The runner ships with Node 12 and Node 16 to execute JavaScript actions. (With Node 12 being deprecated).
Separate from that, the hosted runner images will have a default version of Node - https://github.com/actions/runner-images
That's the version you'd get if you don't use
actions/setup-node
and you reference node from thePATH
.The runner does not use any arbitrary version of Node that's installed on the machine.
So as an action author, you should stick with Node 16 for the foreseeable future. (Matching what you specify in your
action.yml
)
So a .devcontainer.json
is the best way forward to a pleasant dev experience for now. 👍
from fetch-metadata.
Apologies, I'm not very familiar with the Actions/Typescript/Node/NPM ecosystems...
Is there anything (other than time) holding us back from updating this to using the latest node/npm?
Obviously that means this problem will recur down the road, but this project doesn't typically see a lot of traffic, so if we start running into problems again it's probably a good reminder to update...
And this project is pretty simple so AFAIK we don't have a good reason to add a .devcontainer
beyond pinning node/npm for dev purposes...
And to be clear, not asking you to handle that, you are certainly welcome to but if you haven't time we can get to it too at some point.
from fetch-metadata.
From what I understand, the limitation is in Github because the default runners are shipping with the Node 16 runtime
See actions/runner-images#5429 and https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions
Also actions/runner-images#7002 (comment)
I am seeing mixed results from the threads, but it is probably safer to stick with 16 for a little longer (and more so given the differences between GHE and github.com)
To upgrade this action and use anything higher without any dependencies we would need to ask users to use an alternative container. This is technically doable (as it is a single line) but probably not desirable for everyone
from fetch-metadata.
I created a separate issue to track the potential upgrade #335
from fetch-metadata.
Hmm... those threads are confusing. Let me try to get clarity internally.
And yes, we do want to stick with using whatever the default node version is in the runner to make life easy for our users.
from fetch-metadata.
Related Issues (20)
- Fetch Metadata action returns null update-type output for pull requests HOT 14
- Auto-merge not adhering to Branch Protection Rules HOT 3
- Error: Api Error: (404) Not Found HOT 1
- Package ecosystem output for gitsubmodules PRs is inconsistent with dependabot.yml
- `new-version` has trailing whitespace
- Allow for additional event types / Ignore "pull-request"+"pull-request-target" event types? HOT 1
- Support `newVersion` and `prevVersion` for updates with multiple dependencies HOT 2
- Error: github-token is not set! Please add 'github-token: "${{ secrets.GITHUB_TOKEN }}"' to your workflow file. HOT 1
- Add `severity` to the action outputs
- Add alert number to outputs HOT 1
- Alert metadata lookup not working as expected HOT 2
- `fetch-metadata` action returns `/` for directory output HOT 1
- `fetch-metadata` can not fetch metadata when using `workflow_run` event HOT 1
- Directory name is not properly extracted from branch name when using `-` separator. HOT 1
- Multi-segment directory name malformed when using non-standard separator.
- github actor is not dependabot when rerunning the job HOT 1
- Dependabot "update-type" not available in metadata retrieved for PR HOT 6
- Dependabot runs fail due to strict node and npm pinning HOT 5
- Include "outputs.publish-date" HOT 1
- output directory set to target branch name HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fetch-metadata.