Giter Club home page Giter Club logo

Comments (8)

Vinzent03 avatar Vinzent03 commented on May 26, 2024 1

Okay, I will add that.

from obsidian-git.

Vinzent03 avatar Vinzent03 commented on May 26, 2024 1

Yes I thought about something similar.

from obsidian-git.

adam-b-peterson avatar adam-b-peterson commented on May 26, 2024

Thank you for providing such a good idea.
May I know what if I want to use your version, how am I suppose to do?
I tried copying your ts file and edit the existing manifest.json from "js:main.js" to "js:main.ts", but it fails to initialize.

from obsidian-git.

lishid avatar lishid commented on May 26, 2024

You'll want to build the .ts file to a .js version using the build pipeline - just run npm install to install dependencies then npm run build to actually build the final file.

from obsidian-git.

denolehov avatar denolehov commented on May 26, 2024

thank you for the suggestions!

from obsidian-git.

Vinzent03 avatar Vinzent03 commented on May 26, 2024

@lishid You are right, that some users complain about missing settings page or commands, but why should the commands be registered, when the plugin fails in initialization? Other tasks though should of course be moved to other functions.

from obsidian-git.

lishid avatar lishid commented on May 26, 2024

The command could gracefully fail with a message, keeping the plugin experience consistent. Right now the biggest friction is that if something goes wrong, the user has no idea what's going on, or how to solve it, without joining the discord and ask for tips.

from obsidian-git.

lishid avatar lishid commented on May 26, 2024

I'd suggest some way to re-run the initialization process should it fail - then everything else that depends on internal state of the initialization could re-run the initialization step when it's triggered (like showing the settings pane, triggering a command). That way, the user doesn't have to reload the app (or disable/enable the plugin) once they fix the issue.

from obsidian-git.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.