Comments (3)
These aren’t possible to implement without making queries terribly slow because FFI calls won’t be able to take fastpath anymore if callback support is enabled. V8 does not support calling back into JavaScript while in a native context through fast path.
from sqlite3.
Does that perf hit happen only when calling a user-defined function, or does it happen for all queries?
from sqlite3.
Hmm, it is actually possible to make the query take different path if it calls a user defined function. It's just matter of identifying if the query accesses it or not (which I believe is not possible to identify via any SQLite C API). We could make it opt-in to enable callback support (calling user defined functions without it will be undefined behavior; when call is through fast path v8 will crash). That could be either per-statement or just a Database option. Per statement seems more practical though. What do you think?
cc @littledivy
from sqlite3.
Related Issues (20)
- Unsafe pointer create exception HOT 4
- Bug in Reading Integers HOT 1
- `Failed to load SQLite3 Dynamic Library` – example code not working HOT 6
- SQL statement not support chinese ? HOT 1
- Running in a Web Worker HOT 6
- Different API to node-sqlite3 HOT 5
- Error: Failed to load SQLite3 Dynamic Library HOT 3
- Permission denied when trying to only allow access to a certain ffi path HOT 1
- Error: no such table: fsdir HOT 3
- Compiled binary throws zlib dependency error HOT 10
- SQLITE_ENABLE_UPDATE_DELETE_LIMIT does not work on Linux HOT 2
- Allow configuring libsqlite location HOT 2
- bump sqlite bundled version to 3.45 HOT 1
- Extensions and Callbacks prevent using this library with macOS bundled dylib HOT 6
- "TypeError: Invalid ArrayBuffer pointer, pointer is null" while reading blob column HOT 8
- Standardize SQL database interface for TS/JS HOT 1
- `new Database()` in Web Worker freezing HOT 4
- Use tagged releases of SQLite HOT 3
- Open database readOnly not working HOT 3
- Fts5 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqlite3.